Your_Account issue with PM ui-file

Site Admin Joined: Aug 22, 2007 Posts: 1772

Since I'm using php 5.5.x I stumbling over an strange issue in the ui-file of the Private Messages. I'm not sure if it is simply based on a newer mysql version, which comes along with the PHP version inside WAMP.

File: modules/Your_Account/includes/ui-0privmsgs.php

There is an query which counts the messages. But it doesn't show the count of messages - it shows the mysql SELECT value of the query. Try a look on the image below.

To make it clearer let us try a look on the code of this query:

php Code:




	$sql = 'SELECT 1, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_to_userid = ' . $uid . ' AND privmsgs_type IN (0, 1, 5) UNION '


		. 'SELECT 2, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_to_userid = ' . $uid . ' AND privmsgs_type = 0 UNION '


		. 'SELECT 3, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_to_userid = ' . $uid . ' AND privmsgs_type = 1 UNION '


		. 'SELECT 4, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_from_userid = ' . $uid . ' AND privmsgs_type = 2 UNION '


//		. 'SELECT 5, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_to_userid = ' . $uid . ' AND privmsgs_type = 3 UNION '


		. 'SELECT 6, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_from_userid = ' . $uid . ' AND privmsgs_type = 4 UNION '


		. 'SELECT 7, COUNT(*) FROM ' . $prefix . '_bbprivmsgs WHERE privmsgs_to_userid = ' . $uid . ' AND privmsgs_type = 5';


	$result = $db->sql_query($sql);


	list(, $ya_totpms) = $db->sql_fetchrow($result); // 1


	list(, $ya_oldpms) = $db->sql_fetchrow($result); // 2


	list(, $ya_newpms) = $db->sql_fetchrow($result); // 3


	list(, $ya_outpms) = $db->sql_fetchrow($result); // 4


//	list(, $ya_savpms) = $db->sql_fetchrow($result); // 5


	list(, $ya_savpms) = $db->sql_fetchrow($result); // 6


	list(, $ya_outpms) = $db->sql_fetchrow($result); // 7

I tested this issue with fresh installations of RN25 and RN251 where are no PMs - the db-table _bbprivmsgs is empty...

Maybe someone can explain me how should it work.

Site Admin Joined: Jun 04, 2004 Posts: 6432

Looks like the SQLs should just be SELECT COUNT(*) from... or SELECT COUNT(1) from...