News comments displayed out of order bug

Posted: Thu Apr 12, 2007 7:51 am

I fixed this on my old 7.9 site; I noticed it today in RN2.10. Some news comments were getting displayed out of order.

I fixed it by finding this code in the function DisplayTopic in modules/News/comments.php:

Code:




if ($order==1) $q .= " ORDER BY date DESC";


if ($order==2) $q .= " ORDER BY score DESC";

And replacing it with this:

Code:




if ($order==0) $q .= " ORDER BY date";


if ($order==1) $q .= " ORDER BY date DESC";


if ($order==2) $q .= " ORDER BY score DESC";

Posted: Fri Apr 13, 2007 7:05 am

Gremmie, I have added this to our bug tracker (you do know that you have access to that right?). Thank you for this!

I will also move this to the staff Bug Report, as I will assume that you have tested all the various comment threading methods and that this works appropriately for all of them.

Posted: Fri Apr 13, 2007 7:47 am

Sorry I haven't figured out the tracking system yet. Embarassed

I tested all the comment threading orders under 7.9. I did not do that yet on RN2.10.

Posted: Fri Apr 13, 2007 8:30 am

Ok, I tried it out with the two date related comment orderings, but to be honest I have no idea how to change the score on a comment. Smile

Posted: Sun Apr 15, 2007 12:34 pm

No worries m8. I incorporated your change and I just cannot see how it wouldn't be appropriate for all threading types as well.

As far as scoring goes, the "Article Rating" block to the right of the news article (once you are in the article) should be updating the score... hopefully it is. If not, then we have another issue.