RNYA issue on waiting users

Hangin' Around Joined: Nov 07, 2006 Posts: 45

OK I have RN2.3 installed and running and all is well until users signup...

When I go to the RNYA admin section to approve pending users, I click on the "waiting users" tab and it shows me the same information as the regular and active tabs show (note that the number on the tab is displayed correctly). I seem to have no way to get to the pending users.

Site Admin Joined: Jun 04, 2004 Posts: 6433

I haven't seen this behavior. How is your site registration configured? Must you approve members? Is email authentication required?

Posted: Mon Feb 09, 2009 11:13 am

yes and yes..... tell me what all you wish to know and i will post the information...

Posted: Mon Feb 09, 2009 11:39 am

After approving a member with email authentication, the member won't be active / regular until confirming the email authentication. In other words, (s)he will still appear as waiting.

But if the member IS confirmed, it shouldn't be on the waiting tab. I don't think there is an issue with the waiting tab, unless the JS isn't loaded properly.

Can you PM a link to your site, as well as a admin user and password?

Posted: Mon Feb 09, 2009 7:08 pm

OK. The JS is loading correctly, and the links are correct. But even if you access the list directly, it shows the default list of regular users. This indicates a problem with the script file. Can you PM an FTP account so I can compare the source?

I'll take a look at the CSS issue, too.

Posted: Tue Feb 10, 2009 5:49 am

It was a variable conflict. Something you added was clobbering the $query variable used to determine which type of users to list. I changed the variable name in 2 files to resolve this. I'll update the main source copy so future upgrades won't be affected.

Also, I resolved the font color issue so you can see the list now.

Posted: Tue Feb 10, 2009 6:03 am

The conflict is with the Who is Online block. That block uses the same $query variable.

This would also cause problems with other modules that use the $query variable.

Posted: Tue Feb 10, 2009 11:22 am

Ok great and thank you, but what files were modified? I have a couple other installs I am setting up and will need to copy the files over to those as well.

Posted: Tue Feb 10, 2009 11:45 am

These files need to be modified:
modules/Your_Account/admin/activateuserconf.php
modules/Your_Account/admin/approveuserconf.php
modules/Your_Account/admin/deleteuserconf.php
modules/Your_Account/admin/denyuser.php
modules/Your_Account/admin/denyuserconf.php
modules/Your_Account/admin/listusers.php
modules/Your_Account/admin/modifytemp.php
modules/Your_Account/admin/modifytempconf.php
modules/Your_Account/admin/modifyuser.php
modules/Your_Account/admin/modifyuserconf.php
modules/Your_Account/admin/promoteuser.php
modules/Your_Account/admin/removeuser.php
modules/Your_Account/admin/removeuserconf.php
modules/Your_Account/admin/resendmail.php
modules/Your_Account/admin/resendmailconf.php
modules/Your_Account/admin/restoreuser.php
modules/Your_Account/admin/restoreuserconf.php
modules/Your_Account/admin/searchuser.php
modules/Your_Account/admin/suspenduser.php
modules/Your_Account/admin/users.php

But, on your site, I only modified 2 to address the specific problem:
modules/Your_Account/admin/listusers.php
modules/Your_Account/admin/users.php

The other files will work without being modified, but won't return you to the list of users properly after completing the functions they perform. If you like, I can modify those files tonight.

Also, I left the original unmodified files there (renamed, of course).

Posted: Tue Feb 10, 2009 11:55 am

If you could that would be wonderful and then I will just copy the admin folder over to the other sites...... Thanks again and while I hate to see things go wrong with this version of RN, I am glad that in testing people like me can point out things to people like you and get corrections made to future releases of RN

Posted: Tue Feb 10, 2009 11:57 am

No problem. There are several blocks that use the $query variable - none of which are used in testing (but obviously should be). I should have avoided using a common variable name, too. Live and learn... I'll let you know when the changes are completed.

Posted: Tue Feb 10, 2009 10:57 pm

OK. I updated your site to the current version of RNYA (with one exception that involves removing users - I figured you can wait for the upgrade for that and didn't have everything I needed to update your site).

Anyway, I don't think these changes required updates to other files outside of the Your Account module, but I didn't test everything. So you'll need to test. I did notice that the search function had the same issue with disappearing text (white text on a white background), so I corrected that, too, and will update the RavenNuke code to have that as well.

Please let me know if there are issues.