NukeSentinel PHP Compliance Warnings and Errors

Hangin' Around Joined: Jan 01, 2007 Posts: 30

Here is what I am using and the setup of the site.
Fresh install
html plugin for Firefox
Serial Algorithm

Blocked IP Menu
Clear All Blocked IP's
1 error "needs quotes around input type"

Blocked IP Menu
Display Blocked IP's
Steps to reproduce edit blocked ip.
PHP Warning htmlspecialchars() expects parameter 2 to be long, string given in xxxxxx/admin/modules/nukesentinel/ABBlockedIPEdit.php on line 79

Fixing warning should fix compliance errors on page

Blocked IP Menu
Add Blocked IP
1 warning "nested strong"
Steps to reproduce enter non numeric ip.

Blocked Range Menu
Display Blocked Ranges
Steps to reproduce edit blocked ip range.

Notice: Undefined variable: sip in xxxxx/admin/modules/nukesentinel/ABBlockedRangeEdit.php on line 30

Blocked Range Menu
Add Blocked Range
1 warning "nested strong"
Steps to reproduce enter non numeric range.

Excluded Range Menu
Add Excluded Range
1 warning "nested strong"
Steps to reproduce enter non numeric range.

Excluded Range Menu
Display Excluded Ranges
Steps to reproduce edit Excluded ip range.
Notice: Undefined variable: sip in xxxxx/admin/modules/nukesentinel/ABExcludedDelete.php on line 28

Excluded Range Menu
Clear All Excluded Ranges
1 error "needs quotes around input type"

Protected Range Menu
Add Protected Range
1 warning "nested strong"
Steps to reproduce enter non numeric range.

Protected Range Menu
Display Protected Ranges
Notice: Undefined variable: column in xxxxx/admin/modules/nukesentinel/ABProtectedList.php on line 26

Protected Range Menu
Display Protected Ranges
Steps to reproduce edit Protected ip range.
Notice: Undefined variable: sip in xxxxx/admin/modules/nukesentinel/ABProtectedEdit.php on line 30

Protected Range Menu
Clear All Protected Ranges
1 error "needs quotes around input type"

Tracked IP Menu
Display Tracked Users
Under functions for the individual users "Print" one
Notice: Undefined variable: user_id in xxxxx/admin/modules/nukesentinel/ABTrackedUsersPagesPrint.php on line 19

Search Addresses
Search Range Addresses
Steps to reproduce edit Blocked ip range.
Notice: Undefined variable: min inxxxx/admin/modules/nukesentinel/ABBlockedRangeEdit.php on line 33

Notice: Undefined variable: column in xxxxx/admin/modules/nukesentinel/ABBlockedRangeEdit.php on line 34

Notice: Undefined variable: direction in xxxxx/admin/modules/nukesentinel/ABBlockedRangeEdit.php on line 35

Search Addresses
Search Range Addresses
Steps to reproduce edit Protected ip range.
Notice: Undefined variable: min in xxxxx/admin/modules/nukesentinel/ABProtectedEdit.php on line 31

Notice: Undefined variable: column in xxxx/admin/modules/nukesentinel/ABProtectedEdit.php on line 32

Notice: Undefined variable: direction in xxxx/admin/modules/nukesentinel/ABProtectedEdit.php on line 33

Harvester Menu
Display Harvesters
50 errors "all unopened <a> tags"

Referer Menu
Display Referers
50 errors "all unopened <a> tags"

IP to Country Menu
All update links when you click "Let's get started" you get a screen that says "Section 1 of 1 Completed!" that has compliance errors on it.

String Menu
Display Strings
errors "unopened <a> tags as the list is built"

Site Admin Joined: Jun 04, 2004 Posts: 6432

All of these have been fixed except:

IP to Country Menu
All update links when you click "Let's get started" you get a screen that says "Section 1 of 1 Completed!" that has compliance errors on it.

This is because it temporarily disables the site, and the site disabled message is inserted before the opening BODY tag. I'm not sure of a clean way to handle this, since we want this to appear at the top of the site when the site is disabled, but we can modify every theme out there...

Thoughts?

Posted: Mon Aug 09, 2010 7:26 am

I would not worry about it. I do not see any way to make it work short of javascript, but I think that is overkill in my opinion especially since it only shows to an admin.

Posted: Mon Aug 09, 2010 7:46 am

And, it's only temporary during the completion of the task. I agree it's not worth the effort at this time.

All the other changes have been checked in for the 2.41 release.