Web_links Admin Editorial

Regular Joined: Dec 28, 2004 Posts: 94

I've been trying for a while now to change the way adminid acts in displaying the "Editorial by 0" in weblink module. It shows the admin ID instead of the admin username.

I've searched the web for a fix but found none and tried to myself, without success.

Im currently using RP-weblinks but the code is the same for the basic module.

Can any Guru shed any light on this?

Cheers

Trub

Posted: Fri Jun 30, 2006 7:05 pm

This "guru" is puzzled. How do you get to see the "editorial by 0" thing? Can you take me thru the steps to get that far and I'll look in the code to see where it's generated once I can duplicate it on my test site. It may take a day or two or three as I'll be in and out (unless someone else gets to it first).

I don't use weblinks much, never found much use for it. I'd love to find a site that has it set up well and where it serves a useful purpose. Any leads appreciated.

registered · Theme Guru Joined: Nov 01, 2003 Posts: 1006

nsn supporters is much more useful in my opinion. That is what I would choose to use in place of weblinks.

Posted: Sat Jul 01, 2006 8:04 am

I've installed Ravens 7.6 2.02.02 Distro. You do not need to login as the weblinks module is accessable to all.
[ Only registered users can see links on this board! Get registered or login! ]

You will notice that "Alateen" is the first link in there and has now got an editorial link.

Editorials for links can be added to any weblink via ACP - "Modify a Link". this is the only way an editorial can be added. You can not add an editorial through ACP - "Add a New Link". It has to be done when you Modify one.

My other site uses RP Web_Links but has the same problem and the same code to produce and view the Editorial, so if the Basic module can be fixed I'll also be able to fix the other Smile

I've found two functions in modules/weblinks/index.php

The first for displaying the current editorial

Quote:

[0-9]{1,2}) Sad

[0-9]{1,2})", $editorialtimestamp, $editorialtime);
$editorialtime = strftime("%F",mktime($editorialtime[4],$editorialtime[5],$editorialtime[6],$editorialtime[2],$editorialtime[3],$editorialtime[1]));
$date_array = explode("-", $editorialtime);
$timestamp = mktime(0, 0, 0, $date_array['1'], $date_array['2'], $date_array['0']);
$formatted_date = date("F j, Y", $timestamp);
echo "<br><br>";
OpenTable2();
echo "<center><font class=\"option\"><b>'$editorialtitle'</b></font></center>"
."<center><font class=\"tiny\">"._EDITORIALBY." $adminid - $formatted_date</font></center><br><br>"
."$editorialtext";
CloseTable2();
}
} else {
echo "<br><br><center><font class=\"option\"><b>"._NOEDITORIAL."</b></font></center>";
}
echo "<br><br><center>";
linkfooter($lid,$ttitle);
echo "</center>";
CloseTable();
include("footer.php");
}

Which is fine as it is displaying the data given in ACP as $adminid from _links_editorials

The weblinks/admin/index.php has this code to enter the admin id.

Quote:

[0-9]{1,2}) Sad

[0-9]{1,2})", $editorialtimestamp, $editorialtime);
$editorialtime = strftime("%F",mktime($editorialtime[4],$editorialtime[5],$editorialtime[6],$editorialtime[2],$editorialtime[3],$editorialtime[1]));
$date_array = explode("-", $editorialtime);
$timestamp = mktime(0, 0, 0, $date_array['1'], $date_array['2'], $date_array['0']);
$formatted_date = date("F j, Y", $timestamp);
echo "<center><font class=\"option\"><b>Modify Editorial</b></font></center><br><br>"
."<form action=\"".$admin_file.".php\" method=\"post\">"
."" . _AUTHOR . ": $adminid<br>"
."" . _DATEWRITTEN . ": $formatted_date<br><br>"
."<input type=\"hidden\" name=\"linkid\" value=\"$lid\">"
."" . _EDITORIALTITLE . ":<br><input type=\"text\" name=\"editorialtitle\" value=\"$editorialtitle\" size=\"50\" maxlength=\"100\"><br>"
."" . _EDITORIALTEXT . ":<br><textarea name=\"editorialtext\" cols=\"60\" rows=\"10\">$editorialtext</textarea><br>"
."</select><input type=\"hidden\" name=\"op\" value=\"LinksModEditorial\"><input type=\"submit\" value=\"" . _MODIFY . "\"> [ <a href=\"".$admin_file.".php?op=LinksDelEditorial&linkid=$lid\">" . _DELETE . "</a> ]";
}
}
CloseTable();

and the second for updating the database with the new/modified editorial.

Quote:

Im just really unsure on where to edit the second function to update $adminid and whether this will show ID number or Admin Username.

Your help much apprieciated as my sql knowledge is poor.

Trub

P.s. This also applies to Nuke 7.4 as well. Looks like a common error that none have noticed Smile

Posted: Sun Jul 02, 2006 3:49 am

Well...... I totally went off on the wrong track. After looking in the db the correct info was being inserted.

There were two errors however, one in modules/Web_Links/index.php

Quote:

***** FIND *****
$adminid = intval($row['adminid']);

***** REPLACE WITH *****
$adminid = $row['adminid'];

the other in modules/Web_Links/admin/index.php

Quote:

***** FIND *****
while($row3 = $db->sql_fetchrow($resulted2)) {

***** AFTER ADD *****
$adminid = $row3['adminid'];

I think I was looking well too deep and didnt see the forest for the trees Smile

The Editorials now display the Editorial Author Name instead of "0"

Cheers for the replies all.

Trub

Posted: Sun Jul 02, 2006 4:07 am

For RP Web_Links Module change these.

Open root/admin/modules/links.php

Quote:

***** FIND *****
/* if returns 'cool' then status 1 (modify editorial) */
while($row3 = $db->sql_fetchrow($resulted2)) {

***** AFTER ADD *****
$adminid = $row3['adminid'];

Open root/modules/Web_Links/index.php

Quote:

***** FIND *****
$adminid = intval($row['adminid']);

***** CHANGE TO *****
$adminid = $row['adminid'];

Trub

Posted: Sun Jul 02, 2006 7:28 am

Good job! I managed to replicate this, and though it is in a really obscure corner of Nuke, it is a bug. The links_editorial table correctly stores the adminid as the name of the admin but the application of intval causes the bug you see. Probably way back when the programmer thought that adminid was the numeric value of the administrator's id and not his name and was trying to be "safe" by making sure that whatever value was used was an integer.

I will put this thread into our bug tracking system for the next release of Ravennuke and it will get taken care of. Thanks for reporting it and good detective work.