NSN-Downloads breaks under RN 2.4 - [FIXED]

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

did the upgrade. everything stock works fine. but nsn-downloads just gives a blank white page.

I seriously can not remember if I had to edit anything originally (re downloaded the package from nukescripts and over wrote the files still blank page)

I did take out the stock downloads out of RN b4 i did the upload so nothing in the downloads should have got overwrote.

on the white page, page source comes up with nothing.

gazj · Posted: Fri Sep 25, 2009 4:20 pm

turn error reporting on and see if any errors come up then let us know and we can go from there

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

error report on, but getting nothing..

nuken · Posted: Fri Sep 25, 2009 4:34 pm

which version did you download?

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

nuken wrote:

which version did you download?

RN i did the 2.4 upgrade

NSN downloads is 1.0.3 IIRC (latest version i do believe)

nuken · Posted: Fri Sep 25, 2009 4:50 pm

Was it NSN GR Downloads 750 103pl2 or NSN GR Downloads 710 103pl2?

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

nuken wrote:

Was it NSN GR Downloads 750 103pl2 or NSN GR Downloads 710 103pl2?

Downloads 750 103pl2

Palbin · Posted: Fri Sep 25, 2009 6:22 pm

In regards to the blank page are we talking admin or module index?

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

module index.

i turned off shortlinks to see if by some chance that was the cause same issue.

in the admin panel nsn-download admin works fine no issues. im able to see the downloads list,cat list. add download, download config.

something tells me its a code issue but i cant seem to find anything that would cause it but im also no php expert.

Palbin · Posted: Fri Sep 25, 2009 6:34 pm

Try looking in the module index for something like:

Code:

if(!isset($op)) { $op = "index"; }

Change it to:

Code:

if(!isset($op) || empty($op)) { $op = "index"; }

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

code fixed it. now it shows.

what exactly did that do?

Palbin · Posted: Fri Sep 25, 2009 6:47 pm

To fix an undefined $op notice we added some code to set $op to nothing ($op = '') if undefined. This caused a problem with your existing code (obviously).

The reason being is that it is semi poorly written. Ultimately it should of had a default case statement.

Getting back on track, the reason you had a problem is that since we defined $op as blank the "if(!isset($op)) { $op = "index"; }" was not triggering because the variable IS set. When adding the empty() to the if statement it triggers if $op is undefined or empty (ie blank). You probably could have gotten away with changing !isset to empty, but having them both is fine.

Hope you could follow all that Smile

kd8hho · Worker Joined: Mar 30, 2009 Posts: 105

yes indeed. Razz

something in my mind was telling me it was a coding issue. and i was right. just wasnt looking in the right spot evidently lol.