Question about Patched 2.8

Worker Joined: Aug 06, 2004 Posts: 192

Don't these checks now do the same thing?

Code:

if ( !defined('ADMIN_FILE') )


{


   die("Illegal File Access");


}

and

Code:

if (!stristr($_SERVER['SCRIPT_NAME'], "".$admin_file.".php")) {


    die ("Access Denied");


}

Would the define check be quicker than the stristr() and could the same define check be used in place of the stristr() in all the blocks and modules.

Say add something like:

Code:

define('NUKE_FILE', true);

to mainfile.php and use this

Code:

if ( !defined('NUKE_FILE') )


{


   die("Illegal File Access");


}

in the blocks and modules.

Posted: Fri Jan 21, 2005 10:47 am

Now you go ask FB if he wants to that Laughing

Posted: Fri Jan 21, 2005 2:50 pm

So is using a define quicker? If so Chatserv just changed all the calls to eregi() to use stristr() for speed, why not change the patched series to use the defines instead? All the code using the old method will still work.

Posted: Fri Jan 21, 2005 4:52 pm

I'm a CPG Dragonfly coder so i realy don't bother much.

But your point about using

Code:

if (!define())

i agree with you 100%

Posted: Tue Feb 08, 2005 2:43 pm

Just to let people know, the new Patched Version 2.9 will do just that...
[ Only registered users can see links on this board! Get registered or login! ]