converting javascript to inline

Posted: Sun Nov 02, 2014 8:31 am

I found out there lots of javascript code in Your Account module I was trying to converted.

users.php

Code:

    echo '<script type="text/javascript">


          var usercfg=new ddajaxtabs("usertabs", "usertabcontainer")


          usercfg.setpersist('.$persist.')


          usercfg.setselectedClassTarget("link")


          usercfg.init()


          </script>';

Should I convert it like this?

Code:

   $userinlineJS = '


   <script type="text/javascript">


   /* <![CDATA[ */


   $(document).ready(function() {


        var usercfg=new ddajaxtabs(\"usertabs\", \"usertabcontainer\")


        usercfg.setpersist(\'.$persist.\')


        usercfg.setselectedClassTarget(\"link\")


        usercfg.init()


          });


   /* ]]> */


   </script>';


   addJSToBody($userinlineJS, 'inline');

or

Code:

$userinline_js = '<script type="text/javascript">' . PHP_EOL


            . '/* <![CDATA[ */


            . 'var usercfg=new ddajaxtabs(\'usertabs\', \'usertabcontainer\');' . PHP_EOL


            . 'usercfg.setpersist(\'.$persist.\');' . PHP_EOL


            . 'usercfg.setselectedClassTarget(\'link\')' . PHP_EOL


            . 'usercfg.init();' . PHP_EOL


            . /* ]]> */;' . PHP_EOL


            . '</script>' . PHP_EOL;


addJSToBody($userinline_js, 'inline');

Is this the right way? Let me know if I need to add something else.

Site Admin Joined: Aug 22, 2007 Posts: 1772

There is no need to convert it because all is fine.

CDATA is also not needed in this case. [ Only registered users can see links on this board! Get registered or login! ]

Posted: Mon Nov 03, 2014 8:26 am

Wow! I guess u have been search a lot there! Thanks

So it should be

Code:

$userinline_js = '<script type="text/javascript">' . PHP_EOL


            . 'var usercfg=new ddajaxtabs(\'usertabs\', \'usertabcontainer\');' . PHP_EOL


            . 'usercfg.setpersist(\'.$persist.\');' . PHP_EOL


            . 'usercfg.setselectedClassTarget(\'link\')' . PHP_EOL


            . 'usercfg.init();' . PHP_EOL


            . '</script>' . PHP_EOL;


addJSToBody($userinline_js, 'inline');

After doing this I can load includes/tabcontent/tabcontent.js at the end of my page without having any issue. Now I understand why loading all my js files were causing some issues. The only case I still need to figure it out is jquery.js which can not be at the end of the page. Very Happy

Posted: Thu Nov 06, 2014 4:17 am

It's all about the loading order. If I remember correctly tabcontent.js is a plug-in so jquery.js has to be loaded first, otherwise the plug-in will fail.
If I remember correctly (don't have my files in front of me) we load jquery.js by calling jquery.php because there is some logic in there specifically for Your Account.