PHP Notice from 3rd party modules.

Worker Joined: Nov 22, 2004 Posts: 208 Location: Italy

I installed 210 on my local machine and installed also two 3rd party modules I use on my production site. (Sommaire Parametrable and Dynamic module)
I have about 60 Notice from php: undeclared variables and constant already defined.
My knowlegde of php scripting is close to zero: should I get a truckload of aspirin and bother about those notice or just forget about it?
On a positive note, I had only few xhtml compilance issues and already got rid of...
Great job guys!
Guido

Posted: Wed Mar 14, 2007 1:45 pm

If you turn error reporting off you won't see the errors. You could go in and fix them, just like we did with RN2.10 but then again if someone else is responsible for the modules and updates them then you'll just have the errors back. Hummm ... sort like if someone went back to "official" PHPnuke now from RN.

Posted: Thu Mar 15, 2007 6:23 am

Sommaire is absolutely riddled with notices! I concur. I have fixed in the block the XHTML compliance issues, but was absolutely overwhelmed with the number of notices and did not have time myself to even address. Definitely turn off notices as fkelly has suggested, at least on a production web site.

By "Dynamic module" so you mean DynamicTitles? If so, this is already integrated into RavenNuke(tm) and you simply have to turn it ON through the rnconfig.php file.

Posted: Fri Mar 16, 2007 1:48 pm

Montego,
Dynamic Module is the module I use for the recipes, [ Only registered users can see links on this board! Get registered or login! ]
Ok guys thanks! just gimme a shout when someone fix Sommaire because php with french comments and variables just sound like klingon to me LOL!

Posted: Sun Mar 18, 2007 9:15 am

Oh, ok. Got it. Thanks.

Quote:

php with french comments and variables just sound like klingon to me LOL!

I agree and that is why I only fixed the compliance issues in the block itself. I just end up getting lost in the comments and variable names and just don't have that kind of time to figure it out. Sad

Involved Joined: Apr 22, 2006 Posts: 356

Montego, is the menu download on your site, somewhat compliant?

Posted: Sat Mar 24, 2007 8:28 am

Unfortunately, no. I have not had time to make a download. Been very hesitant to support the add-on too because of the difficulty with understanding the french comments and variable names. I can send you just my block for the 3.0 beta version if you PM me your email address.

I have done NOTHING to fix all the warning messages (i.e., when error reporting is turned up) as it is a complete mess. In addition, I have not touched the admin code at all either. So, just the menu block.

Posted: Mon Mar 26, 2007 7:44 pm

ok, I may be a bit confused. I am using a league module on my site. I am starting to try to compare code from files within it to files in rn2.10 and see what obvious code changes I can find to change. I have turned error reporting on and for some reason, do not see them. Is there something I am missing?

Sorry for my ignorance!

Posted: Tue Mar 27, 2007 6:33 am

No problem. Open up rnconfig.php and make this change:

$error_reporting = E_ALL;

and then make sure in config.php that error reporting is TRUE. You will be amazed what you find (I hope anyways)!