Missing Link - Fix

Posted: Sun Oct 07, 2007 2:36 am

I use also the NSN Group Downloads Module and i missed the ReportBrokenDownloadLink for the users.

Here my Fix:
Open modules/Downloads/public/getit.php
find:

Code:

echo "<center><font class='content'>[ <a href='modules.php?name=$module_name&amp;op=modifydownloadrequest&amp;lid=$lid'>"._MODIFY."</a> ]</font></center>\n";

replace with:

Code:

echo "<center><font class='content'>[ <a href='modules.php?name=$module_name&amp;op=modifydownloadrequest&amp;lid=$lid'>"._MODIFY."</a> ]


      [ <a href='modules.php?name=$module_name&amp;d_op=brokendownload&amp;lid=$lid'>"._REPORTBROKEN."</a> ]</font></center>\n";

Coldy

Posted: Mon Oct 08, 2007 8:56 am

Thanks for this. I have captured this as an enhancement for a 1.1.0 version.

Posted: Tue Oct 09, 2007 9:05 am

Coldy does this work for you without issues? I can see the report broken downloads link logged in as member but I don´t see any reported broken downloads logged in as admin. Maybe its a short links problem too.
Beneed this I don´t see a "Thanks for your report"or something.

Posted: Tue Oct 09, 2007 11:57 pm

@Susann

Yes, there are some small changes in the mainfile.php for the Waiting Content.
Find:

Code:

$content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=downloads">'._UDOWNLOADS.'</a>: '.$num.'<br />';


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadsListModRequests">'._MODREQDOWN.'</a>: '.$modreqd.'<br />';


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadsListBrokenDownloads">'._BROKENDOWN.'</a>: '.$brokend.'<br /></span>';

Replace with:

Code:

$content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadNew">'._UDOWNLOADS.'</a>: '.$num.'<br />';


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadModifyRequests">'._MODREQDOWN.'</a>: '.$modreqd.'<br />';


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadBroken">'._BROKENDOWN.'</a>: '.$brokend.'<br /></span>';

The "Thanks for the Report" i see, but i test it only without ShortLinks.
There are also some changes to made.
for Example:
The missing BrokenDownload link in the GT-Downloads.php (urlin)

Code:

"'(?<!/)modules.php\?name=Downloads&amp;d_op=brokendownload&amp;lid=([0-9]*)'",

rewrite to (urlout):

Code:

"download-broken-\\1.html",

and in htaccess:

Code:

RewriteRule ^download-broken-([0-9]*).html modules.php?name=Downloads&d_op=brokendownload&lid=$1

But i haven't test it yet - i search only for bugs in it at this time.

Coldy Cool

Posted: Thu Oct 11, 2007 4:24 pm

Coldy thanks I´ll wait until there is a new release available maybe that solves my errors.

Regular Joined: Dec 28, 2004 Posts: 94

Susan

I've also needed to change the SQL query for this in mainfile.php function adminblock

it now reads and works Smile

Code:

    $brokend = $db->sql_numrows($db->sql_query("SELECT * FROM ".$prefix."_nsngd_mods WHERE brokendownload='1'"));


    $modreqd = $db->sql_numrows($db->sql_query("SELECT * FROM ".$prefix."_nsngd_mods WHERE brokendownload='0'"));


    $newd = $db->sql_numrows($db->sql_query("SELECT * FROM ".$prefix."_nsngd_new"));


      $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadNew">'._UDOWNLOADS.'</a>: '.$newd.'<br />'; 


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadModifyRequests">'._MODREQDOWN.'</a>: '.$modreqd.'<br />'; 


        $content .= '<strong><big>&middot;</big></strong>&nbsp;<a href="'.$admin_file.'.php?op=DownloadBroken">'._BROKENDOWN.'</a>: '.$brokend.'<br /></span>';

Posted: Wed Mar 12, 2008 5:28 am

Trubador thanks a lot. Thats great !

Posted: Sun Feb 20, 2011 4:23 pm

The reporting of a broken link has been fixed in 1.1.0... still not released but getting closer.