RavenPHPScripts Banner click opens 404 if admin.

PHP Web Host - Quality Web Hosting For All PHP Applications

Clan Themes! We make clans look good!!

Login or Register

• Home • Downloads • Your Account • Forums •

Forum FAQ • Search • Memberlist • Usergroups • Profile • Log in to check your private messages • Log in

Banner click opens 404 if admin.

View next topic
View previous topic

Ravens PHP Scripts And Web Hosting Forum Index » phpnuke 7.3

Author

Message

djw2
Regular
Regular

Regular

Joined: Sep 19, 2003
Posts: 95
Location: St. Louis, MO

Posted: Sun Jun 20, 2004 12:12 pm

Reply with quote

Hey,

I went to test a banner I had installed and it opened a 404 when I clicked it. Just for the sake of trying I thought it might have something to do with me being logged as an admin. so I logged out and clicked the banner again, this time it worked. So whatever it is... only happens when I'm admin.

I opened my theme.php and found a "if (!is_admin($admin)" function, I wonder if that might be where the problem is?

I'm using a bit of an older theme but it seems to be working well... other than this of course. Confused

Confused

I'm not actually sure the theme is related to the bug, but it's my hunch.

Here's the function themeheader from my theme.

Code:

function themeheader() {
global $admin, $user, $banners, $sitename, $slogan, $cookie, $prefix, $db, $nukeurl, $anonymous;
if ($banners == 1) {
$numrows = $db->sql_numrows($db->sql_query("SELECT * FROM ".$prefix."_banner WHERE type='0' AND active='1'"));
/* Get a random banner if exist any. */
/* More efficient random stuff, thanks to Cristian Arroyo from http://www.planetalinux.com.ar */

if ($numrows>1) {
$numrows = $numrows-1;
mt_srand((double)microtime()*1000000);
$bannum = mt_rand(0, $numrows);
} else {
$bannum = 0;
}
$sql = "SELECT bid, imageurl, clickurl, alttext FROM ".$prefix."_banner WHERE type='0' AND active='1' LIMIT $bannum,1";
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$bid = $row[bid];
$imageurl = $row[imageurl];
$clickurl = $row[clickurl];
$alttext = $row[alttext];

if (!is_admin($admin)) {
$db->sql_query("UPDATE ".$prefix."_banner SET impmade=impmade+1 WHERE bid='$bid'");
}
if($numrows>0) {
$sql2 = "SELECT cid, imptotal, impmade, clicks, date FROM ".$prefix."_banner WHERE bid='$bid'";
$result2 = $db->sql_query($sql2);
$row2 = $db->sql_fetchrow($result2);
$cid = $row2[cid];
$imptotal = $row2[imptotal];
$impmade = $row2[impmade];
$clicks = $row2[clicks];
$date = $row2[date];

/* Check if this impression is the last one and print the banner */

if (($imptotal <= $impmade) AND ($imptotal != 0)) {
$db->sql_query("UPDATE ".$prefix."_banner SET active='0' WHERE bid='$bid'");
$sql3 = "SELECT name, contact, email FROM ".$prefix."_bannerclient WHERE cid='$cid'";
$result3 = $db->sql_query($sql3);
$row3 = $db->sql_fetchrow($result3);
$c_name = $row3[name];
$c_contact = $row3[contact];
$c_email = $row3[email];
if ($c_email != "") {
$from = "$sitename <$adminmail>";
$to = "$c_contact <$c_email>";
$message = ""._HELLO." $c_contact:\n\n";
$message .= ""._THISISAUTOMATED."\n\n";
$message .= ""._THERESULTS."\n\n";
$message .= ""._TOTALIMPRESSIONS." $imptotal\n";
$message .= ""._CLICKSRECEIVED." $clicks\n";
$message .= ""._IMAGEURL." $imageurl\n";
$message .= ""._CLICKURL." $clickurl\n";
$message .= ""._ALTERNATETEXT." $alttext\n\n";
$message .= ""._HOPEYOULIKED."\n\n";
$message .= ""._THANKSUPPORT."\n\n";
$message .= "- $sitename "._TEAM."\n";
$message .= "$nukeurl";
$subject = "$sitename: "._BANNERSFINNISHED."";
mail($to, $subject, $message, "From: $from\nX-Mailer: PHP/" . phpversion());
}
}
$showbanners = "<center><a href=\"banners.php?op=click&bid=$bid\" target=\"_blank\"><img src=\"$imageurl\" border=\"0\" alt='$alttext' title='$alttext'></a></center>";
}
}
cookiedecode($user);
$username = $cookie[1];
if ($username == "") {
$username = "Anonymous";
}
echo "<body bgcolor=\"#000000\" text=\"#000000\" leftmargin=\"10\" topmargin=\"10\" marginwidth=\"10\" marginheight=\"10\">";

if ($username == "Anonymous") {
$theuser = "  <a href=\"modules.php?name=Your_Account&op=new_user\">Create an account";
} else {
$theuser = "  Welcome $username!";
}
$tmpl_file = "themes/Coldsteel/header.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
blocks(left);
$tmpl_file = "themes/Coldsteel/left_center.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
}

Any help on this will be much appreciated.

Peace!

Send private message

Send e-mail

Visit poster's website

MSN Messenger

Raven
Site Admin/Owner

Joined: Aug 27, 2002
Posts: 16987
Location: Kansas

Posted: Mon Jun 21, 2004 6:40 am

Reply with quote

I don't think that's the problem. That piece of code simply tells the system to only update the impressions counter if the person clicking on it is NOT an admin.

Send private message

Visit poster's website

AIM Address

Yahoo Messenger

Ravens PHP Scripts And Web Hosting Forum Index » phpnuke 7.3

Jump to:

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

All logos and trademarks in this site are property of their respective owner.
The comments are property of their posters, all the rest © 2002-2011 by Raven

You can syndicate our news using the file

xml

Website engines core code is © copyright by PHP-Nuke but has been heavily patched and modified by myself and others.
PHP-Nuke is a free software released under the GNU/GPL.

:: fisubice phpbb2 style by Daz :: PHP-Nuke theme by www.nukemods.com :::: fisubice Theme Modified by the RavenNuke™ Team ::
::

::

::