Joined: Jun 03, 2004 Posts: 177 Location: Tamworth, UK
Posted:
Sun Mar 21, 2010 2:20 pm
Hi Guys;;myself and one of the users on the site have been working on a "new" theme for RN;
based on charcoal2 by nukemods (phpbb part by zarron media), with parts "borrowed" from ct_rn_black, plus some of our own stuff.
I need help, if possible (some of this is probably going to take me longer to work out on my own, so I thought I'd ask more knowledgeable for help)
When I put it through the w3c validator, it fails. Nothing major, but trying to pinpoint the source of errors could be.... "fun"
I'm about to zip the file up, and make it available to anyone that can help.
My other concern is regarding "legalities"- I need to make sure what I've done is ok, and I've left all the copyrights/ credited original authors where possible.
The html validator here on RN gives me the following errors:
Code:
Messages
Type Line Message
Error 196 The "script" element cannot be used here. It is not contained in an element that allows its use. This element may be contained in "body" and "head".
Error 196 The "center" element cannot be used here. It is not contained in an element that allows its use. This element may be contained in "body", "dd", "td", and "th".
Error 204 The "tr" element cannot be used here. It is nested in another "tr" tag and cannot be nested. Has the previous "tr" element been ended with an end tag? This element may be contained in "table". This element may not be contained in "tr".
<tr>
Error 207 The end tag for "tr" (started in line 202) should appear before the end tag for "table" (nesting error).
</table>
Error 210 The "div" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "dd", "td", and "th". This element may not be contained in "dl" and "table".
Error 210 The "div" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "dd", "td", and "th". This element may not be contained in "dl" and "table".
Error 210 The "ul" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "dd", "li", "td", and "th". This element may not be contained in "dir", "dl", "menu", and "table".
Error 210 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 212 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 214 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
<li><a title="">Forums</a>
Error 216 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 217 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
<li><a href="forums.html&file=search&search_id=newposts" title="">New Forum Posts</a></li>
Error 218 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 221 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 221 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 222 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 223 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
<li><a href="top.html">Top 10</a></li>
Error 225 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 227 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 228 The "a" element cannot be used here. It is contained in a "table" tag that cannot contain it. This element may be contained in "body", "caption", "td", and "th". This element may not be contained in "a", "button", and "table".
Error 231 Terminating validation due to too many errors. Please correct the previous errors and recheck the document. HTML Validator is currently set to stop checking after 20 errors.
<li><a title="">Site Info</a>
I'm hoping, if everyone thinks it's good enough, to make it available to others, free of charge ;I've made notes, in case anyone needs/ wants to change the colour scheme, which files need changing other than the style.css
We've tried to put all style requirements into style.css (including nukeNAV.css AND forumstyle.css)
It's NOT a fixed width design, and it also has the random image portion at the top (save your images in one folder and it will work through them, the same way as ct_rn_black/ red/grey/etc.
Joined: Jun 03, 2004 Posts: 177 Location: Tamworth, UK
Posted:
Mon Mar 22, 2010 6:44 am
quick one; when viewed in Firefox or Chrome, it appears as above- text aligned left, etc.
When using Opera or Internet Explorer, the text is centered. There's nothing in the css files, OR theme.php that has an alignment attribute of center- anyone any ideas?
You need to add that script to the addJSToHead array to load it properly (this will only work on RN 2.4+). Add this near the top of your theme.php (after the opening php tag)
Code:
// Theme specific config script
include_once INCLUDE_PATH . 'themes/afnet_grey/afnet.php';
and create a new file (this is missing the opening/closing php tags)
themes/afnet_grey/afnet.php
Joined: Jun 03, 2004 Posts: 177 Location: Tamworth, UK
Posted:
Mon Mar 22, 2010 9:28 am
thanks for that (would never have known about that- any of it ) - all help is appreciated
My theme.php is below (I'll remove the opening and closing tags out, and hope it works)
I think my biggest problem (as always!) is getting tables wrapped around my head... always given me grief... lol
Code:
// Theme specific config script
include_once INCLUDE_PATH . 'themes/afnet_grey/afnet.php';
/************************************************************/
/* Theme Name: afnet_grey */
/* Theme Design: Audifans.net / CASWeb Solutions */
/* */
/* Copyright Notice(read and understand) */
/* - THIS PACKAGE IS NOT RELEASED AS GPL/GNU SCRIPTING. */
/* */
/* - Author names and Credit links MUST REMAIN in the */
/* credit line footer of all Nuke generated pages. */
/* */
/* - Translations are permitted, not renaming. */
/* */
/* - ANY UNAUTHORIZED USE OF THESE MATERIALS */
/* MAY VIOLATE COPYRIGHTS and/or TRADEMARKS. */
/* */
/* - This package CAN NOT be mirrored without written */
/* permission. */
/* */
/* - ADDITIONAL COPYRIGHTS BY TEMPLATE AUTHORS APPLY */
/* */
/* - FULL LICENSE - http://www.nukemods.com */
/* */
/************************************************************/
/************************************************************/
/* Theme Colors Definition */
/* */
/* Define colors for your web site. $bgcolor2 is generaly */
/* used for the tables border as you can see on OpenTable() */
/* function, $bgcolor1 is for the table background and the */
/* other two bgcolor variables follows the same criteria. */
/* $texcolor1 and 2 are for tables internal texts */
/************************************************************/
/************************************************************/
/* OpenTable Functions */
/* */
/* Define the tables look&feel for you whole site. For this */
/* we have two options: OpenTable and OpenTable2 functions. */
/* Then we have CloseTable and CloseTable2 function to */
/* properly close our tables. The difference is that */
/* OpenTable has a 100% width and OpenTable2 has a width */
/* according with the table content */
/************************************************************/
function OpenTable2() {
global $bgcolor1, $bgcolor2;
echo "<table border=\"0\" cellspacing=\"1\" cellpadding=\"0\" bgcolor=\"$bgcolor2\" align=\"left\"><tr><td>\n";
echo "<table border=\"0\" cellspacing=\"1\" cellpadding=\"8\" bgcolor=\"$bgcolor1\"><tr><td>\n";
}
function CloseTable2() {
echo "</td></tr></table></td></tr></table>\n";
}
/************************************************************/
/* Function themeheader() */
/* */
/* Control the header for your site. You need to define the */
/* BODY tag and in some part of the code call the blocks */
/* function for left side with: blocks(left); */
/************************************************************/
/************************************************************/
/* Function themefooter() */
/* */
/* Control the footer for your site. You don't need to */
/* close BODY and HTML tags at the end. In some part call */
/* the function for right blocks with: blocks(right); */
/* Also, $index variable need to be global and is used to */
/* determine if the page your're viewing is the Homepage or */
/* and internal one. */
/************************************************************/
/************************************************************/
/* Function themeindex() */
/* */
/* This function format the stories on the Homepage */
/************************************************************/
/************************************************************/
/* Function themearticle() */
/* */
/* This function format the stories on the story page, when */
/* you click on that "Read More..." link in the home */
/************************************************************/
/************************************************************/
/* Function themesidebox() */
/* */
/* Control look of your blocks. Just simple. */
/************************************************************/
Joined: Jun 03, 2004 Posts: 177 Location: Tamworth, UK
Posted:
Tue Mar 30, 2010 12:44 am
quick update;
some of this is still giving us "issues"- it's definitely something to do with the tables, etc. It only affects some certain versions of browsers, not all of them. Where possible we've asked users to upgrade their browsers, but rather than asking them to do something as a "fix" I'd rather get it fixed at our end.
The file above has been changed slightly, and has rid us of some errors, but still the problem persists (some users have to scroll across to the right in a BIG way to see the site)
Joined: Dec 02, 2006 Posts: 1251 Location: Texas, USA
Posted:
Tue Mar 30, 2010 6:51 am
I would use Firefox with the HTML Validator addon
Only registered users can see links on this board! Get registered or login to the forums!
it will show the compliance errors and even give an example how to fix.
right now you are missing the body tag which gives alot of compounding warnings, so fix that and you will see the warning count go down significantly.
Code:
</head>
<tr>
<td>
then concentrate on any errors with tables and divs. You'll see a fair amount of errors for tags not being closed properly for xhtml, which aren't critical but you can fix if you like
Joined: Dec 02, 2006 Posts: 1251 Location: Texas, USA
Posted:
Tue Mar 30, 2010 7:29 am
here's the link directly from mozilla
Only registered users can see links on this board! Get registered or login to the forums!
at one point I had to download from author's site due to using a recently released version of firefox, so that's why I gave the direct link... but maybe that will work for you
Joined: Jun 03, 2004 Posts: 177 Location: Tamworth, UK
Posted:
Tue Jul 13, 2010 3:28 am
can anyone take a quick look, and provide any "tips"- I'm sure there's still something "amiss"- some users get it thrown over to the right- this is down to browser of the user, I think.
Only registered users can see links on this board! Get registered or login to the forums!
View next topic View previous topic
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum