Edit banner name bug

wHiTeHaT · Posted: Sat Jul 18, 2009 8:25 am

Before posting i checked , checked again..and again etc etc.
but i dont find it.

when try to edit a banners name:
(modules/Advertising/admin/index.php)

Code:

echo '<tr><td>' . _BANNERNAME . ':</td><td><input type="text" name="adname" size="20" maxlength="50" value="' . $row['name'] . '" /></td></tr>';

It wont update , i checked on my localhost ravennuke distro (latest as we speak), and ther it also doesnt update.
Same for the release BEFORE latest (as we speak)
So i checked a version phpnuke81035b , and there it is working.
i did a file comparsion but couldnt locate any real serious differency?

Raven · Posted: Sat Jul 18, 2009 6:11 pm

Have you checked your server error log? Also try turning on the following settings in rnconfig.php and then checking your logs?

$error_reporting = E_ALL;
$loglevel = 1;

wHiTeHaT · Posted: Sun Jul 19, 2009 2:26 am

Find in your ROOT/modules/Advertising/admin/index.php around line: 698

Code:

$db->sql_query('UPDATE ' . $prefix . '_banner set cid=\'' . $cid . '", name="' . $adname . '\', imptotal=\'' . $imp . '\', imageurl=\'' . $imageurl . '\', clickurl=\'' . $clickurl . '\', alttext=\'' . $alttext . '\', position=\'' . $position . '\', active=\'' . $active . '\', ad_code=\'' . $ad_code . '\', ad_width=\'' . $ad_width . '\', ad_height=\'' . $ad_height . '\' where bid=\'' . $bid . '\'');

Replace with:

Code:

$db->sql_query('UPDATE ' . $prefix . '_banner set cid=\'' . $cid . '\', name=\'' . $adname . '\', imptotal=\'' . $imp . '\', imageurl=\'' . $imageurl . '\', clickurl=\'' . $clickurl . '\', alttext=\'' . $alttext . '\', position=\'' . $position . '\', active=\'' . $active . '\', ad_code=\'' . $ad_code . '\', ad_width=\'' . $ad_width . '\', ad_height=\'' . $ad_height . '\' where bid=\'' . $bid . '\'');

fkelly · Posted: Sun Jul 19, 2009 8:20 am

Thanks Whitehat. This bug has been fixed as part of RN2.4. There is another bug with renaming a client name that is fixed. In fact, there's a number of bugs that will be fixed.

If folks aren't comfortable editing their SQL they can wait a bit for 2.4.

wHiTeHaT · Posted: Sun Jul 19, 2009 3:10 pm

Thank you aswell , i found the cliënt name renaming bug aswell and fixed it.

Is there a bug repository?

jakec · Posted: Sun Jul 19, 2009 3:38 pm

There is, but currently it is for internal use only.

fkelly · Posted: Sun Jul 19, 2009 6:31 pm

Here is the new SQL for the BannerClientChange function in Advertising/Admin/index.php:

Code:

$db->sql_query('UPDATE ' . $prefix . '_banner_clients SET name=\'' . $name . '\', contact=\'' . $contact . '\', email=\'' . $email . '\', login=\'' . $login . '\', passwd=\'' . $passwd . '\', extrainfo=\'' . $extrainfo . '\' WHERE cid=\'' . $cid . '\'');

For what it is worth, the problem was most likely caused by extensive efficiency based changes to the code to substitute string concatenation and single quotes in earlier Ravennuke releases. I recommend that most users just wait for 2.4 but if you have a backup and are affected by the client name rename bug and are comfortable editing PHP code then the correct code is above.

There will be many other changes to the advertising module of a bug fix nature in 2.4. It's just not practical to be posting them individually as we go but if a particular issue comes up we will try to respond.