Module Compatibility Issues with Nuke versions

Gremmie · Posted: Thu Jan 04, 2007 8:46 am

What version of Nuke did the if (!defined(BLOCK_FILE)), ADMIN_FILE, and MODULE_FILE convention get introduced?

I'm trying to write a module that will be compatible with 7.6 - 8.0 (and RavenNuke of course Wink

). I've only been testing on 7.9 so far. Just wondering what other gotchas await me. Thanks.

fkelly · Posted: Thu Jan 04, 2007 9:05 am

I believe these constructs were part of the patches that Chatserv introduced. I just looked at a "base" 7.6 distribution that I have and the changes weren't in there. Then I looked at patched 7.6 and the changes were. I've never looked at PHPnuke beyond 7.6 (and never will) so I can't say whether the esteemed author ever got around to incorporating those changes.

Gremmie · Posted: Thu Jan 04, 2007 9:52 am

Ok thanks. Wow...so what do you guys think? Use the "define" convention or the older (and stupider) eregi()/strstr() thing?

montego · Posted: Thu Jan 04, 2007 6:06 pm

Definitely use the define convention. I have adopted the position myself as a module developer to "encourage" the nuke web master community to get with the "patch program"!

You don't patch, you must like to get hacked... Wink

Gremmie · Posted: Thu Jan 04, 2007 6:36 pm

I tend to agree with you, but it would definitely narrow the nukes my module would work on. Perhaps I will go the define route, but then offer instructions on how to convert it to the old way along with a stern warning encouraging the use of the patches.

montego · Posted: Thu Jan 04, 2007 6:38 pm

It really is a patch issue and not a nuke version, with the exception of course if you intend on supporting nukes that patches are no longer supported on.

However, I certainly understand where you are coming from. I finally "broke down" and place a sticky in my forum, but I definitely do not encourage it.

evaders99 · Posted: Thu Jan 04, 2007 6:57 pm

Note that FB does add these patches to phpNuke... eventually. 8.0 uses an older version with these constants. Smile

Gremmie · Posted: Thu Jan 04, 2007 9:34 pm

Oh man..... Well any more advice on what I should do? If I use the defines, it will work out of the box on any Nuke that has the patches, and 8.0 (oh boy). I could make a statement by using the defines, but maybe narrow my audience a lot.

If I don't use the defines it will work on all (?) Nukes.

It's probably not that big a deal to go ahead and do it the non-define way I guess. Hmmm...

montego · Posted: Fri Jan 05, 2007 6:28 am

Personally, I've had very few issues with going the define route. Most people are using the patches if they know anything about nuke, and if they are not, they should be "educated". I simply put a sticky in my support forum with how to address the "You can't access this file directly" error message and my support questions ceased...