nukeICONS, icon themes for RavenNuke/PHP-Nuke

horrorcode · Posted: Fri Mar 20, 2009 9:30 pm

About to start testing this now, was and still am pretty interested but for some reason I lost track. Thanks for bumping it, this may come in handy if I can figure out how the functions work, may help with the theme Im designing.

duck · Involved Joined: Jul 03, 2006 Posts: 267

I think the idea and concept is a great idea but I am curious how it works with backwards compatibility?

I am working on a project that is meant to have several modules built to be added to nuke and I have started witha new system when building my modules whereby I am making templates for the layout of the module info. I have a function I call which checks to see if a template exists in the users theme folder for the module it parses that one first if not then it parses the default one I've supplied with the module. This way theme makers (or site owners for that matter) will be able to enhance some of my new modules if they like and give them a whole new layout effect. Something like your iconizer could do asimilar thing and or be something useful to add to my template thing? Good work though!

eldorado · Posted: Sat Mar 21, 2009 6:29 am

i'm installing it just now.

jestrella · Posted: Sat Mar 21, 2009 8:23 am

Great... post your impressions here

horrorcode · Posted: Sun Apr 19, 2009 3:05 am

Sorry I didnt post back here sooner. So far it works great, but I did have a few issues getting it to work in the first place.

In class.nukeicons the spaces before the alt werent working, I left them alone and added spaces after the img src, for example like this:

Code:

$return = '<img src="icon/'.$this->IconTheme.'/'.$this->IconSize.'/status/image-missing.'.$this->IconExt.'" ';

Another thing I have to note, for some reason on my server apache doesnt allow an icons directory, so I had to change all instances of icons to icon.

Other then that I got it working, and the icon test page looks great, for testing I changed to the dev1 version though, which can be seen

Only registered users can see links on this board!
Get registered or login to the forums!

Do you have more documentation on how the function can be called for specific icons etc?

One thing I almost left out... transparent pngs don't display properly in some browsers, for instance IE... Any chance of being able to use multiple formats, and/or including a js fix for that issue?

jestrella · Posted: Tue Apr 21, 2009 8:32 am

@ duck, what do you mean by backwards compatibility?

@ horrorcode, no documentation is currently available, I will be doing some test and try to correct those issues

duck · Involved Joined: Jul 03, 2006 Posts: 267

Well I reread things a little and I am still a little confused to this things full purpose and structure? As for backwards compatibility after rereading I see there is none. To use this new system requires modification of existing files to work which really there wouldn't be a lot of choice I assume.

But when it boils down to it what you are looking for is suggestions for improvement and at quick glance after downloading your package here is what I noticed that I think might make improvement but they are just quick thoughts that might need more evaluation to determine practicality or to see if there are even better ideas.

I notice there is no default settings for Attributes (though I suppose one could edit the class to do so). But I am also thinking perhpas something like extracting the image name minus the extension for Alt Title tags and actual size of icon without having to send dimensions . I mean without some of these things one is almost typing as much info to display an icon as it would be to echo out the img tag itself.

Also if it were me I think I might consider sending all the attributes as an array instead of singular variables. hopefully reducing typing even more and at least reducing the size ofthe function call.

Again these are just ideas trying to put forth incase for your consideration since you were looking for input.

As I say I am still a little confused how this is fully meant to work but it appears you've done a good effort at it.

jestrella · Posted: Tue Apr 21, 2009 10:43 am

Thanks for your input duck.

To clarify you what I try to do with it... This intends to unify the graphical look on *nuke throughout the system, as we have it now all modules are using different set of graphics/icons, with this I pretend to give *nuke a unique graphical appearance.

Hope this is clear enough now, Laughing

duck · Involved Joined: Jul 03, 2006 Posts: 267

I looked at your class a little more closely and I think I see the picture you are painting a little better now.

Ok so here are a couple other improvements I might suggest too.

How about separating the Icon path from the output so you can set the icon path via a public method. This will help for those times someone wants to override the default path for certain icons as well you could also make this become more standardized with this cause you could include a check for Users current theme then check to see if an icons folder exists within the theme folders and if so display those by default for that theme. This way Theme Authors could create their own set of icons that are packaged within the theme itself that are used with that theme for users using that theme. I would maybe include one more Public method and variable that turns this on and off (on by default).

LAstly how about a default set of Admin Icons too or a function that reads the modules name and looks for an Icon in the icons/admin folder of that name and if so displays it if not reads the module icon as set in the links file. Then theme makers can add their own admin icons as well to packages more easily.

I think I had one more idea that I forgot as I started typing but if it comes back to me I'll let you know.

jestrella · Posted: Tue Apr 21, 2009 12:03 pm

Once again, thanks for your input. You have some very good points Very Happy