Several issues after clean install

jakec · Posted: Wed Nov 19, 2008 1:29 am

rose38478, we never actually figured out what the bug was on your site, so IF it is a bug with RN we aren't going to fix it because we don't know what it is yet. From what you have said I very much suspect it is a combination of your theme and the $dbi issue.

Can you confirm what theme you are using and where you downloaded it from? This way we can try and replicate the problem you are having.

It is difficult for us to ensure all themes will work with RN, most will without a problem, but we don't have the time to check every theme, it is really the responsibility of the author and webmaster. Of course we are keen to help wherever possible. Wink

rose38478 · Regular Joined: Jul 22, 2005 Posts: 78

Yep, got it from Kaglesh themes. As I mentioned before, it's a copyright 2006 theme, so it's older. It's the Lineage theme.

There are only two things that don't work with RN version 2.3 that I saw in my testing. One is the "confirm" button on new user registration and the other is the "hit count" on the Site Info block. Other than that, once you uncomment those two lines everything else seems to work. However, I didnt add anything additional to the site as I was trying to get that problem fixed first.

Anyway, at the moment, I am quite pleased with my site with the previous version of RN, though I would like to upgrade to the current version. The new "Your Account" module alone makes it worth it.

Thanks for all your help as always.

montego · Posted: Wed Nov 19, 2008 6:30 am

rose38478, I hate to hear of you going back to 2.2. The reason is we, with each release, tighten up security holes. What Doulos isn't really an RN bug, its a theme integration issue. Unless you work through this to find the conflict in that specific theme, its could always be an issue with upgrading even later. Sad

jakec · Posted: Wed Nov 19, 2008 7:10 am

I'll try and get a copy of the theme and work out the issue. Although it might not be a quick response at the moment, hopefully the weekend. If someone else has time please feel free to take a look. Wink

rose38478 · Regular Joined: Jul 22, 2005 Posts: 78

Well, if you guys can get an answer to this, I'd love to upgrade. I couldn't figure it out and you guys are so busy, I didn't want to keep bothering everyone, so I made a "temporary fix" so to speak.

Thanks again for all your help.

testy1 · Involved Joined: Apr 06, 2008 Posts: 483

I would say other things would be missing from the theme also like attachment mod?

Is there an upgrade guide at all on what was added to the themes?

Guardian2003 · Posted: Thu Nov 20, 2008 7:12 am

testy1 wrote:

I would say other things would be missing from the theme also like attachment mod?

Is there an upgrade guide at all on what was added to the themes?

Only what is provided in the packages AddOnFiles/attachment_mod directory I do not think there is any other documentation.
The problem is, the themes can vary so much.
Some use only a theme.php and tables.php whilst others use a lot of seperate html files which are then eval()'d.
Themes coded for pre *nuke 7.9 use $banners instead of $ads.
Themes not written to take security improvements into account use variable $index instead of the constant INDEX_FILE.
Themes which include there own forum template files are rarely (if ever) updated to accomodate phpBB/ BBtoNuke changes.
99.9% of all nuke themes are (at best) written to the W3C HTML 4.01 standard which can sometimes cause layout problems due to RN's stricter XHTML 1.0 Transitional doctype.

testy1 · Involved Joined: Apr 06, 2008 Posts: 483

maybe just stick to supplying what ever was added in each version.Apart from compliancy changes.

Guardian2003 · Posted: Thu Nov 20, 2008 7:40 am

I'm pretty sure all of the above info will either be in this sites FAQ's and/or as stickies in the appropriate forums or in another topic I posted this info in recently.
I wish I could find the time to write a full 'how to' including specific changes required to make old themes compliant etc as it is something I have wanted to do for some time.
We definitely need more documentation for everything but to paraphrase a well known quote, you can take a horse to the library but you cannot make him read a book Smile

Doulos · Posted: Thu Nov 20, 2008 12:56 pm

I have converted a couple of Kalgash themes to work with RN2.30.

Try this theme.php for Lineage:

Code:

<?php

/*************************************************************************************************/
/* */
/* Theme Name: Lineage 1.0 */
/*             Created by Mistique */
/* Copyright (c) 2006 Kalgash Themes ( http://www.kalgash.com ) */
/* Last Updated: 18/12/2006 */
/* */
/************************************************************************************************/

$bgcolor1 = "#011F39";
$bgcolor2 = "#011F39";
$bgcolor3 = "#011F39";
$bgcolor4 = "#011F39";
$textcolor1 = "#B0AB92";
$textcolor2 = "#B0AB92";

include("themes/Lineage/tables.php");
if($_REQUEST["name"] == "Your_Account"){

}else{
echo "<script language=\"JavaScript\">";
echo "startColor=\"#9B8F86\";";
echo "endColor=\"#C5B178\"; ";
echo "</script> ";
echo "<script language=\"JavaScript\" src=\"themes/Lineage/fade.js\">";
echo "</script>";
}
/************************************************************/
/* Function themeheader() */
/* */
/* Control the header for your site. You need to define the */
/* BODY tag and in some part of the code call the blocks */
/* function for left side with: blocks(left); */
/************************************************************/

function themeheader() {
global $user, $banners, $sitename, $slogan, $cookie, $prefix, $db, $name, $nukeurl, $anonymous, $name, $admin_file;
cookiedecode($user);
$username = $cookie[1];
if ($username == "") {
$username = "Anonymous";
}

/***********************************************************************/
/* Flash Sitename Settings */
/* */
/* Define the Sitename and Slogan text */
/* Modify $yoursitename and $yourslogan variables with your own data. */
/***********************************************************************/

$yoursitename = "Your Site Name";
$yourslogan = "--- Add Your Slogan Here ---";

/********************* End of Sitename Settings ***********************/

/******************************************************************************/
/* Flash Menu Settings */
/* */
/* Define the buttons text and link urls */
/* Modify $btxt1, $btxt2, etc. variables to select the text for each button. */
/* Modify $url1, $url2, etc. variables to select the url for each button. */
/******************************************************************************/

$btxt1 = "Home";
$btxt2 = "Forums";
$btxt3 = "Downloads";
$btxt4 = "Your Account";

$url1 = "index.php";
$url2 = "forums.html";
$url3 = "modules.php?name=Downloads";
$url4 = "modules.php?name=Your_Account";

/************************ End of Flash Menu Settings **************************/

$flashmenu = "themes/Lineage/flash/inf2.swf?btxt1=$btxt1&url1=$url1&btxt2=$btxt2&url2=$url2&btxt3=$btxt3&url3=$url3&btxt4=$btxt4&url4=$url4";
echo "<body leftmargin=\"1\" rightmargin=\"1\" topmargin=\"0\" bgcolor=\"#1B1B1B\" text=\"#858C82\" link=\"#6A7067\">";
if ($banners == 1) {
$showbanners = ads(0);
}
echo "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\" align=\"center\"><tr><td class=\"lat1\"></td><td rowspan=\"3\">\n";

$topics_list = "<select name=\"new_topic\" onChange='submit()'>\n";
$topics_list .= "<option value=\"\">All Topics</option>\n";
$toplist = $db->sql_query("select topicid, topictext from ".$prefix."_topics order by topictext", $db);
while(list($topicid, $topics) = $db->sql_fetchrow($toplist, $db)) {
if ($topicid==$topic) { $sel = "selected "; }
$topics_list .= "<option $sel value=\"$topicid\">$topics</option>\n";
$sel = "";
}
if ($username == "Anonymous") {
$theuser = "  <a href=\"modules.php?name=Your_Account&op=new_user\">Create an account";
} else {
$theuser = "  Welcome $username!";
}
$tmpl_file = "themes/Lineage/header.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
blocks(left);
$tmpl_file = "themes/Lineage/left_center.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
$public_msg = public_message();
echo "$public_msg ";
}

/************************************************************/
/* Function themefooter() */
/* */
/* Control the footer for your site. You don't need to */
/* close BODY and HTML tags at the end. In some part call */
/* the function for right blocks with: blocks(right); */
/* Also, $index variable need to be global and is used to */
/* determine if the page your're viewing is the Homepage or */
/* and internal one. */
/************************************************************/

function themefooter() {
global $index, $foot1, $foot2, $foot3, $copyright, $totaltime;
if (defined('INDEX_FILE')) {
$tmpl_file = "themes/Lineage/center_right.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
blocks(right);
}
$footer_message = "$foot1<br>$foot2<br>$foot3<br>$copyright<br>$totaltime<br><a href=\"http://www.kalgash.com\">Lineage PHP-Nuke Theme By Kalgash Themes</a>";
$tmpl_file = "themes/Lineage/footer.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
echo"</td><td class=\"lat2\"></td></tr></table>";
}

/************************************************************/
/* Function themeindex() */
/* */
/* This function format the stories on the Homepage */
/************************************************************/

function themeindex ($aid, $informant, $time, $title, $counter, $topic, $thetext, $notes, $morelink, $topicname, $topicimage, $topictext) {
global $anonymous, $tipath;
$ThemeSel = get_theme();
if (file_exists("themes/$ThemeSel/images/topics/$topicimage")) {
$t_image = "themes/$ThemeSel/images/topics/$topicimage";
} else {
$t_image = "$tipath$topicimage";
}
if ($notes != "") {
$notes = "<br><br><b>"._NOTE."</b> <i>$notes</i>\n";
} else {
$notes = "";
}
if ("$aid" == "$informant") {
$content = "$thetext$notes\n";
} else {
if($informant != "") {
   $content = "<a href=\"modules.php?name=Your_Account&op=userinfo&username=$informant\">$informant</a> ";
} else {
   $content = "$anonymous ";
}
$content .= ""._WRITES." <i>\"$thetext\"</i>$notes\n";
}
$posted = ""._POSTEDBY." ";
$posted .= get_author($aid);
$posted .= " "._ON." $time $timezone ($counter "._READS.")<br>";
$tmpl_file = "themes/Lineage/story_home.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
}

/************************************************************/
/* Function themearticle() */
/* */
/* This function format the stories on the story page, when */
/* you click on that "Read More..." link in the home */
/************************************************************/

function themearticle ($aid, $informant, $datetime, $title, $thetext, $topic, $topicname, $topicimage, $topictext) {
global $admin, $sid, $tipath;
$ThemeSel = get_theme();
if (file_exists("themes/$ThemeSel/images/topics/$topicimage")) {
$t_image = "themes/$ThemeSel/images/topics/$topicimage";
} else {
$t_image = "$tipath$topicimage";
}
$posted = ""._POSTEDON." $datetime "._BY." ";
$posted .= get_author($aid);
if ($notes != "") {
$notes = "<br><br><b>"._NOTE."</b> <i>$notes</i>\n";
} else {
$notes = "";
}
if ("$aid" == "$informant") {
$content = "$thetext$notes\n";
} else {
if($informant != "") {
   $content = "<a href=\"modules.php?name=Your_Account&op=userinfo&username=$informant\">$informant</a> ";
} else {
   $content = "$anonymous ";
}
$content .= ""._WRITES." <i>\"$thetext\"</i>$notes\n";
}
$tmpl_file = "themes/Lineage/story_page.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
}

/************************************************************/
/* Function themesidebox() */
/* */
/* Control look of your blocks. Just simple. */
/************************************************************/

function themesidebox($title, $content) {
$content=str_replace("<strong><big>·</big></strong>"," ",$content);
$content=str_replace("<strong>·</strong>"," ",$content);
$content=str_replace("<strong><big>·</big></strong>"," ",$content);
$tmpl_file = "themes/Lineage/blocks.html";
$thefile = implode("", file($tmpl_file));
$thefile = addslashes($thefile);
$thefile = "\$r_file=\"".$thefile."\";";
eval($thefile);
print $r_file;
}

?>

I was able to register a new user with this theme. You will need to make the appropriate changes for you specific site.

Also add these 4 files from a theme that is RN2.30 compliant (like fisubice) to /themes/Lineage/forums folder:

add_attachment_body.tpl
posted_attachments_body.tpl
posted_attach_body.tpl
posted_atach_rules.tpl

I do not claim this theme.php complies with all the standards of RN2.30, only that I made changes until there were no more php errors thrown.

jakec · Posted: Thu Nov 20, 2008 2:21 pm

Cheers Doulos, that's one less thing to look at this weekend.

testy1 · Involved Joined: Apr 06, 2008 Posts: 483

rose38478,

zip the theme up and pm me a link and I will look at it for you if you like.