second HTML header in the forum files?

64bitguy · Posted: Thu Nov 09, 2006 8:20 am

Glad I could help. Again, W3C Compliance is one of the base functions that I have been working on for a few years. Bitching about nuke's lack of compliance and taking steps to make it compliant is what I've spent most of my time on (ask anyone).

Glad I could help, even though you'd have to put a gun to my head to get me to load IE7 on my computers. Smile

Gremmie · Posted: Thu Nov 09, 2006 8:30 am

I'm only running IE cause the majority of my users run it... Sad

I think your simple system of having individual css files for modules should be adopted by Nukes. Thats pretty cool, very easy to implement, and very easy to maintain.

I'll see if I can tame the rest of those link problems tonight. I'm really surprised the phpBB people didn't notice that? Or maybe it only happens when the css is placed in an external file.... Confused

One last question for now, what is the simple_header.tpl used for? I just noticed I did not clean out the header and css from it. I only did the overall_header.tpl.

Thanks again. Groovy

64bitguy · Posted: Thu Nov 09, 2006 9:31 am

The simple_header.tpl is used for all popups (notifications of new PM's, Search for user boxes as well as when you are previewing forum replies, (as the bottom box that shows the previous posts "includes/topic_review.php"). This is why fixing it is so important, especially when wrapped in a nuke theme.

If you use the format that I described on my website for the simple_header.tpl, you'll be fine and at the same time, you'll be fixing a couple of hundred compliance errors (including major compliance errors).

Steph

Gremmie · Posted: Thu Nov 09, 2006 6:57 pm

Hey, one (last???) question...I noticed you just hardcoded a path to a theme in your simple_header.tpl file. I've only got 1 theme on my site so thats fine with me. Would we have to add a parameter or something to the template for the current theme if we wanted to be general?

I've got all my link changes in place...I think its working..! Thanks again.

fkelly · Posted: Thu Dec 07, 2006 9:06 am

Wow ... I don't know how I missed this thread when it first came out and I wish I hadn't. I've been working on a couple of the themes for RN 2.10 (Slash and SlashOcean) and making them compliant. As I think you know from looking at the code, there were over 200 validation errors in these themes on a typical home page when I started. That's fixed now but the style sheet issues you both covered are still existing and we won't have time to address that in RN 2.10. But later ...

Back about six months ago I was looking into some styles issues and developed a couple of spreadsheets to help me analyze how styles are contained in themes. I've decided to post the spreadsheets here, on my test Ravennuke 2.10 site:

Only registered users can see links on this board!
Get registered or login to the forums!

Anyone who has Excel should be able to open them and even save them should you choose. You'll note that the site is running Slash as the default theme, that's part of what I'm testing. Feel free to look around with the knowledge that it's a test area and subject to change at any minute.

My initial idea was to consolidate the redundant styles between themes into one master style sheet that would be loaded in header.php then each theme would only need to load the "difference". Eventually someone developing a theme could use the master style sheet as a source and not have to develop a whole list of styles for their theme, just styles for where they want to override. This seems to me to be important especially as we move towards using more styles in our themes.

I can see from this thread that we will have to do some work on the Forums styles area too. And the one thing that "bugs" me about that is the question about how we preserve any changes we make across any further bbtonuke upgrades.

By the way if you see any errors on the test site please email me so I can look into them. Notices are turned on and I have a little sql error trapper running so I can find any issues with RN2.10 before it's released.