Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Ravens PHP Scripts And Web Hosting Forum Index -> Raven's RavenNuke(tm) v2.02.02 Distro
Author Message
hinksta
Worker
Worker


Joined: Dec 23, 2005
Posts: 226
Location: UK

PostPosted: Sun Apr 23, 2006 5:19 am Reply with quote

Is it just me or does the weblinks module have a similar error to the Feedback and Recomend_Us modules?

My weblinks page does not see the language files.
 
View user's profile Send private message Visit poster's website
montego
Site Admin


Joined: Aug 29, 2004
Posts: 9456
Location: Arizona

PostPosted: Sun Apr 23, 2006 7:25 am Reply with quote

Well, the Feedback module and Recommend_Us modules were not core nuke modules, but the Web Links module is core 7.6. Have you noticed this before?

Sorry hinksta, its been awhile, can you repost the link to your site or PM it to me? Also, please let me know language is not showing up properly for you.

_________________
Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website
hinksta
PostPosted: Sun Apr 23, 2006 7:39 am Reply with quote

not noticed it before, using english lang

the www link will take you to the site
 
montego
PostPosted: Sun Apr 23, 2006 7:45 am Reply with quote

"WWW" Blonde Moment

Looking at it now...
 
montego
PostPosted: Sun Apr 23, 2006 7:52 am Reply with quote

hinksta, this doesn't make sense to me. I am not seeing the same thing with my 2.02.02 version. I have also checked the patch files for 2.02.00 to 2.02.02 and I even checked the SVN change log and nothing related to language defines have changed.

You need to check to see if your Web Links language files are missing or re-FTP them.
 
hinksta
PostPosted: Sun Apr 23, 2006 8:09 am Reply with quote

re uploaded v2.01.00 weblinks

did index.php update from v2.02.02

that worked

thanks for the new hair colour Embarassed
 
montego
PostPosted: Sun Apr 23, 2006 7:35 pm Reply with quote

hinksta, I was having the Blond Moment not you! Wink
 
benson
Worker
Worker


Joined: May 15, 2004
Posts: 119
Location: Germany

PostPosted: Sat Apr 29, 2006 9:59 am Reply with quote

Hello,
since the sorting options are displayed with a 'D' and 'A', I think it means 'Ascending and Descending, in the Weblinks module I recommend to change the following part in the index.php:
Code:
    echo "<center><font class=\"content\">"._SORTLINKSBY.": "

        .""._TITLE." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=titleA\">A</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=titleD\">D</a>) "
        .""._DATE." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=dateA\">A</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=dateD\">D</a>) "
        .""._RATING." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=ratingA\">A</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=ratingD\">D</a>) "
        .""._POPULARITY." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=hitsA\">A</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=hitsD\">D</a>)"
   ."<br><b>"._SITESSORTED.": $orderbyTrans</b></font></center><br><br>";

to that one:
Code:
    echo "<center><font class=\"content\">"._SORTLINKSBY.": "

        .""._TITLE." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=titleA\">"._SORTA."</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=titleD\">"._SORTD."</a>) "
        .""._DATE." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=dateA\">"._SORTA."</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=dateD\">"._SORTD."</a>) "
        .""._RATING." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=ratingA\">"._SORTA."</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=ratingD\">"._SORTD."</a>) "
        .""._POPULARITY." (<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=hitsA\">"._SORTA."</a>\<a href=\"modules.php?name=$module_name&amp;l_op=viewlink&amp;cid=$cid&amp;orderby=hitsD\">"._SORTD."</a>)"
   ."<br /><b>"._SITESSORTED.": $orderbyTrans</b></font></center><br /><br />";


additional you must add the two lines into the language file:
Code:
define("_SORTA","<img src=\"images/SortA.gif\" border=\"0\" alt=\"A\" width=\"9\" height=\"8\" hspace=\"0\">");

define("_SORTD","<img src=\"images/SortD.gif\" border=\"0\" alt=\"D\" width=\"9\" height=\"8\" hspace=\"0\">");


Than we have these two pictures (Image/Image) in the sorting option instead of a (hardcoded Wink) 'A' and 'D'.

An additional advantage is, that you can change the images in the language file, e.g. with a term like (aufwärts/abwärts) ... Laughing

What do you think ?

Regards, Benson
 
View user's profile Send private message Visit poster's website
montego
PostPosted: Sun Apr 30, 2006 9:15 am Reply with quote

Benson,

Your insistence upon cleaning up the hardcoding of literals is being heard! Just wanted you to know that. We have a project on our "plate" to review all of the code for such and modify it. I will a reference to this post in our assigned issue for this.

Now, we are human beings, so we won't catch everything, so when newer releases come out, please keep sending us these finds! Thanks!
 
benson
PostPosted: Sun Apr 30, 2006 11:33 am Reply with quote

Hello,
sorry, I just thought that some pictures looks nicer than D or A in that module.
Regards, Benson
 
montego
PostPosted: Sun Apr 30, 2006 12:31 pm Reply with quote

No problem. Again, thank you.
 
kenwood
Worker
Worker


Joined: May 18, 2005
Posts: 119
Location: SVCDPlaza

PostPosted: Sun Apr 30, 2006 12:49 pm Reply with quote

don't forget to replace name=\"op with name=\"l_op\"
 
View user's profile Send private message Visit poster's website
Display posts from previous:       
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Ravens PHP Scripts And Web Hosting Forum Index -> Raven's RavenNuke(tm) v2.02.02 Distro

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©