Shout Box Compatiblity Issues

Posted: Thu Jan 03, 2013 10:20 am

Have recently read about the use of /* <![CDATA[ */ causing issues, and I have my shout box block being used in my Forums.

Now the problem is, I am browsing my site via Safari and noticed the Shout Box is showing on my home page, but not in the forums, and not really sure what the issue is there, only thing I could think of is the following code:

Code:




<script type="text/javascript">


/* <![CDATA[ */


var SBheight = '<?php echo "$ShoutMarqueeheight"; ?>';


var SBcontent = new String('<?php echo "$mid_content"; ?>');


/* ]]> */


</script>


<script type="text/javascript" src="shoutbox.js"></script>


<?php





$content = "$top_content\n";


$content .= "<div align=\"left\"><script type=\"text/javascript\">document.write(SBtxt);</script></div>\n";


$content .= "$bottom_content\n";





?>

Posted: Thu Jan 03, 2013 10:26 am

Do you see that code when you view the source code when in Forums?
The chances are that this was made for a block file, which automatically executes any data assigned to $content, anywhere else, you may need to actually echo $content at the bottom of the file

Posted: Thu Jan 03, 2013 10:32 am

Nevermind, I guess the issue has to due with being a registered member to view the shout box in the forums.

Posted: Thu Jan 03, 2013 9:27 pm

Back to this topic, what is the proper fix for document.write in XHTML?
In this code, it has validation errors:
I've tried doing <\/script>, or putting the SBtxt in ' or ".
But doesn't fix it.

Code:




<script type=\"text/javascript\">document.write(SBtxt);</script>

In /blocks/block-Shout_Box.php
Line: 722-735

Code:




<script type="text/javascript">


/* <![CDATA[ */


var SBheight = '<?php echo "$ShoutMarqueeheight"; ?>';


var SBcontent = new String('<?php echo "$mid_content"; ?>');


/* ]]> */


</script>


<script type="text/javascript" src="shoutbox.js"></script>


<?php





$content = "$top_content\n";


$content .= "<div align=\"left\"><script type=\"text/javascript\">document.write(SBtxt);</script></div>\n";


$content .= "$bottom_content\n";





?>

Posted: Thu Jan 03, 2013 9:56 pm

What are the errors you are getting?

Posted: Thu Jan 03, 2013 10:09 pm

XHTML documents may not use document.write() or document.writeln(), and it appears that this is used in this script. Use the innerHTML property instead.

and

This document contains 1 possibly problematic CDATA section. Using CDATA sections is not recommended due to poor browser support (even some newer browsers fail to properly support it) and due to other complications. AI Internet Solutions recommends avoiding CDATA sections if possible or commenting them out (for example, using "//<![CDATA[" and "//]]>" in a "script" element).