Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> RavenNuke(tm) v2.5x
Author Message
Dawg
RavenNuke(tm) Development Team



Joined: Nov 07, 2003
Posts: 924

PostPosted: Mon Aug 20, 2012 3:36 pm Reply with quote

Greetings All,

I was in need a new Menu System for RN...So I wrote one.

This is a simple to use Menu system with admin panel.

You can create a Category, Name the Category, Link the Category, Choose the CSS for it, select an image from pre-uploaded images and pick a rank (order).

Then you can create a link, Name the Link, Pick the Category for the link, Choose the CSS for it, select an image from pre-uploaded images and pick a rank (order).

Any feedback anyone has good or bad, I am all ears.

I will also try to help with any problems.
[ Only registered users can see links on this board! Get registered or login! ]

If you have any problems just let me know.

Dawg
 
View user's profile Send private message
neralex
Site Admin



Joined: Aug 22, 2007
Posts: 1513

PostPosted: Mon Aug 20, 2012 4:21 pm Reply with quote

after a first view in the admin section, i have some questions:

1. why don't you write it all in php - why html and then php?
2. why do you use stripslashes?
3. why do you use unneeded double qoutes in places where you can use simply quotes?
4. why don't you use the RN functions to integrate JS code?
5. why do you use mysql_error(), if we have rnlogs for putting out sql errors.

Sorry, it looks old code styling....
 
View user's profile Send private message
Dawg







PostPosted: Mon Aug 20, 2012 4:58 pm Reply with quote

neralex wrote:
after a first view in the admin section, i have some questions:

1. why don't you write it all in php - why html and then php?
2. why do you use stripslashes?
3. why do you use unneeded double qoutes in places where you can use simply quotes?
4. why don't you use the RN functions to integrate JS code?
5. why do you use mysql_error(), if we have rnlogs for putting out sql errors.

Sorry, it looks old code styling....


Cause I suck.....and I admit it. You have never heard me say I am some guru. I needed it....and I wrote what I needed the way I knew how to do it. It works...

Dawg
 
neralex







PostPosted: Mon Aug 20, 2012 5:09 pm Reply with quote

Dawg, nobody has said you are a guru but as a part of RavenNuke(tm) Development Team i thought you know the functions of the current RN. Sorry for that but it makes me a little bit confused.
 
Dawg







PostPosted: Mon Aug 20, 2012 5:18 pm Reply with quote

I am...I do the end user part. You know the part where people actually use it and break it. Stress testing...That's me.

If you would like to point the way

Give me an example of how I can do better...I will be happy to go through it again.

As long as it is not insecure...or broke. I'm happy!

I wrote this a year or so back. Been using it ever since. Works like a champ!


Dawg
 
hicuxunicorniobestbuildpc
The Mouse Is Extension Of Arm



Joined: Aug 13, 2009
Posts: 1008
Location: Netherland

PostPosted: Tue Aug 21, 2012 3:51 am Reply with quote

Hi Dawg,

OLD

Code:
 if (!eregi("admin.php", $_SERVER['PHP_SELF'])) { die ("Access Denied"); }


New

Code:
if (!defined('ADMIN_FILE')) { die('Access Denied'); }


Wink

Old

Code:
<table border="0" cellpadding="0" width="100%">


New

Code:
<table style="width:100%;" border="0" cellpadding="0">


OLD
Code:
                                            echo "<input type='radio' name='c_img' value='$file'>";

                                            echo "<img src='$path/$file' alt='$file'><br />";


NEW but HTML
Code:


                                            echo "<input type='radio' name='c_img' value='$file' />";
                                            echo "<img src='$path/$file' alt='$file' /><br />";


NEW and XHTML

Code:
                                            echo '<input type="radio" name="c_img" value="$file" />';

                                            echo '<img src="$path/$file" alt="$file" /><br />';


Note: Neralex is right, I am also learning and learning. Sometimes I get stuck and I start again and again until I get a good results. I think it is a little bit difficult and lots of work but as soon as you get used to will success and your site will be 100% validated and secured.

Note: I just finished checking your codes. Pretty old and sit down because it could take some days to clean this addon. Shocked
 
View user's profile Send private message Visit poster's website
neralex







PostPosted: Tue Aug 21, 2012 4:19 am Reply with quote

unicornio wrote:

Code:
<table style="width:100%;" border="0" cellpadding="0">



The table-tag need the attribute width="100%" for a clear validation, with td you can use it but not with table.

unicornio wrote:
... it could take some days to clean this addon. Shocked


Yes its an massive work to rebuild this script to the current standard.
 
Dawg







PostPosted: Tue Aug 21, 2012 4:39 am Reply with quote

neralex wrote:


Yes its an massive work to rebuild this script to the current standard.


Your Cracking me up....

The whole thing is not but 4 files....

Thanks for the heads up! and the feedback.

That is what I was looking for.

Dawg
 
nextgen
Worker
Worker



Joined: Sep 28, 2006
Posts: 227
Location: Maryland

PostPosted: Thu Aug 23, 2012 8:16 am Reply with quote

I love the idea of this module. Was tinkering with something similar but kind of like a Mega Menu. I soon found it was just a "bit" to advanced for someone with my limited knowledge to try to do.

_________________
alterednuke.com Your source for Ravennuke themes. 
View user's profile Send private message Send e-mail Visit poster's website Yahoo Messenger MSN Messenger
jestrella
Moderator



Joined: Dec 01, 2005
Posts: 593
Location: Santiago, Dominican Republic

PostPosted: Wed Aug 29, 2012 8:40 am Reply with quote

may I have some screenshots? Smile

_________________
"For those whom have not reach the sky... Every mountain seems high"

Best Regards
Jonathan Estrella [ Only registered users can see links on this board! Get registered or login! ] 
View user's profile Send private message Visit poster's website
Dawg







PostPosted: Wed Aug 29, 2012 9:26 am Reply with quote

Jestrella,

It takes less time to install it as it would to take screenshots and upload them and then link them here.

While they do not like that I used tables in it. It works fine and as far as I can tell is secure.

Pop it in and try it out. It is a simple MOD.

Dawg

PS...
Check your PM's...I will send you a couple of links.
 
jestrella







PostPosted: Wed Aug 29, 2012 9:39 am Reply with quote

Thanks Dawg, I really appreciate it.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> RavenNuke(tm) v2.5x

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©