Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> RavenNuke(tm) v2.5x
Author Message
neralex
Site Admin



Joined: Aug 22, 2007
Posts: 1531

PostPosted: Tue Jul 10, 2012 8:08 am Reply with quote

Hey guys!

I have found an issue, if i try to delete an forum posting. In the confirm section (YES/NO) was loaded after the nuke footer an empty posting formular and i don't found the solution to delete this formular. I get this problem in all themes of the RN25 package.

raven25/modules.php?name=Forums&file=posting&mode=delete&p=5

Confused


Last edited by neralex on Wed Jul 11, 2012 2:03 pm; edited 3 times in total 
View user's profile Send private message
hicuxunicorniobestbuildpc
The Mouse Is Extension Of Arm



Joined: Aug 13, 2009
Posts: 1014
Location: Netherland

PostPosted: Tue Jul 10, 2012 7:19 pm Reply with quote

WOW! I didn't notice that until now. you are right! Shocked

I think it is the QUICK_REPLY_FORM which is not in the correct place. I am searching on viewtopic_body.tpl
 
View user's profile Send private message Visit poster's website
neralex







PostPosted: Wed Jul 11, 2012 1:35 pm Reply with quote

Idea was good, but not the solution

Crying or Very sad
 
neralex







PostPosted: Wed Jul 11, 2012 2:02 pm Reply with quote

next try:

open: modules/Forums/posting.php

find:

Code:
$template->pparse('body');


replace it:

Code:
if( $mode != 'delete' ) {

   $template->pparse('body');
}


I hope it works in all functions...
 
hicuxunicorniobestbuildpc







PostPosted: Wed Jul 11, 2012 4:48 pm Reply with quote

neralex, the problem has been solved. Thanks buddy. We need to do this steps to all the themes.
 
montego
Site Admin



Joined: Aug 29, 2004
Posts: 9457
Location: Arizona

PostPosted: Sat Jul 14, 2012 10:22 am Reply with quote

Ok, I have added this to our bug tracker. Thanks!

_________________
Where Do YOU Stand?
HTML Newsletter::ShortLinks::Mailer::Downloads and more... 
View user's profile Send private message Visit poster's website
Palbin
Site Admin



Joined: Mar 30, 2006
Posts: 2583
Location: Pittsburgh, Pennsylvania

PostPosted: Sun Jul 15, 2012 4:54 pm Reply with quote

The proper thing to do is add an exit after line 475.
Code:


        include_once("modules/Forums/includes/page_tail.php");
        exit;
}

_________________
"Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan. 
View user's profile Send private message
hicuxunicorniobestbuildpc







PostPosted: Sun Jul 15, 2012 5:25 pm Reply with quote

Palbin, this doesn't work. I get a blank page when I delete a forum. I look on the file posting.php and there are 2 lines which contains this

Code:
include_once("modules/Forums/includes/page_tail.php");
This one is around 653, I added your code but no luck.

At the end we also have the same and it doesn't work neither.
 
Palbin







PostPosted: Sun Jul 15, 2012 6:21 pm Reply with quote

Are you sure you just added the "exit;" and nothing else? Make sure you did not add a trailing "}". Your file should look like this: [ Only registered users can see links on this board! Get registered or login! ]
 
hicuxunicorniobestbuildpc







PostPosted: Sun Jul 15, 2012 6:49 pm Reply with quote

yes I'm very sure, it is not working Shocked
 
montego







PostPosted: Sat Jul 21, 2012 10:19 am Reply with quote

how about

die();

instead of:

exit;
 
hicuxunicorniobestbuildpc







PostPosted: Sat Jul 21, 2012 2:00 pm Reply with quote

palbin, after taking a look on your file I must say it is working. The problem was I commented this code out. It is working find exit;

Code:
//$template->pparse('body');
]

It should be in the bottom like this

Code:
$template->pparse('body');


        include_once("modules/Forums/includes/page_tail.php");


your trick works

Code:
   $template->pparse('confirm_body');


        include_once("modules/Forums/includes/page_tail.php");
        exit;
}
else if ( $mode == 'vote' )
{
 
neralex







PostPosted: Sun Jul 22, 2012 3:57 am Reply with quote

cool, thanks!
 
neralex







PostPosted: Sat Jan 19, 2013 7:27 am Reply with quote

I have found the same issue in the Private Messages module, when i'm trying to delete all messages.

open modules/Private_Messages/index.php:

search:

Code:
   if ( !$confirm ) {

      $s_hidden_fields = '<input type="hidden" name="mode" value="' . $mode . '" />';
      $s_hidden_fields .= ( isset($HTTP_POST_VARS['delete']) ) ? '<input type="hidden" name="delete" value="true" />' : '<input type="hidden" name="deleteall" value="true" />';
      $s_hidden_fields .= '<input type="hidden" name="sid" value="' . $userdata['session_id'] . '" />';

      for($i = 0; $i < count($mark_list); $i++) {
         $s_hidden_fields .= '<input type="hidden" name="mark[]" value="' . intval($mark_list[$i]) . '" />';
         }

      //
      // Output confirmation page
      //
      include_once($phpbb_root_path . 'includes/page_header.'.$phpEx);

         $template->set_filenames(array(
               'confirm_body' => 'confirm_body.tpl')
         );

         $template->assign_vars(array(
               'MESSAGE_TITLE' => $lang['Information'],
               'MESSAGE_TEXT' => ( count($mark_list) == 1 ) ? $lang['Confirm_delete_pm'] : $lang['Confirm_delete_pms'],

               'L_YES' => $lang['Yes'],
               'L_NO' => $lang['No'],

               'S_CONFIRM_ACTION' => append_sid("privmsg.$phpEx?folder=$folder"),
               'S_HIDDEN_FIELDS' => $s_hidden_fields)
         );

         $template->pparse('confirm_body');

         include_once($phpbb_root_path . 'includes/page_tail.'.$phpEx);

   }


search in this part the last include_once and add exit; after this line:


Code:
   if ( !$confirm ) {

      $s_hidden_fields = '<input type="hidden" name="mode" value="' . $mode . '" />';
      $s_hidden_fields .= ( isset($HTTP_POST_VARS['delete']) ) ? '<input type="hidden" name="delete" value="true" />' : '<input type="hidden" name="deleteall" value="true" />';
      $s_hidden_fields .= '<input type="hidden" name="sid" value="' . $userdata['session_id'] . '" />';

      for($i = 0; $i < count($mark_list); $i++) {
         $s_hidden_fields .= '<input type="hidden" name="mark[]" value="' . intval($mark_list[$i]) . '" />';
         }

      //
      // Output confirmation page
      //
      include_once($phpbb_root_path . 'includes/page_header.'.$phpEx);

         $template->set_filenames(array(
               'confirm_body' => 'confirm_body.tpl')
         );

         $template->assign_vars(array(
               'MESSAGE_TITLE' => $lang['Information'],
               'MESSAGE_TEXT' => ( count($mark_list) == 1 ) ? $lang['Confirm_delete_pm'] : $lang['Confirm_delete_pms'],

               'L_YES' => $lang['Yes'],
               'L_NO' => $lang['No'],

               'S_CONFIRM_ACTION' => append_sid("privmsg.$phpEx?folder=$folder"),
               'S_HIDDEN_FIELDS' => $s_hidden_fields)
         );

         $template->pparse('confirm_body');

         include_once($phpbb_root_path . 'includes/page_tail.'.$phpEx);
         exit; // neralex 190113

   }
 
hicuxunicorniobestbuildpc







PostPosted: Sat Jan 19, 2013 5:52 pm Reply with quote

OMG, are u kidding me? I can't believe this. I'm gonna check this right now.

Hi, I just tried to delete all messages and everything went smooth. I am not able to reproduce this error. I don't get it. Shocked
 
neralex







PostPosted: Sat Jan 19, 2013 7:51 pm Reply with quote

Believe what do you want... i can only say what i have seen. I have here 4 local installations and with the core package without any mods i get this error. Try it again an scroll down, when you get the question: YES or NO
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> RavenNuke(tm) v2.5x

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©