Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> nukeFeed/FeedCreator
Author Message
Brujo
Regular
Regular


Joined: Jun 04, 2004
Posts: 84
Location: Germany

PostPosted: Sat Apr 12, 2008 6:44 am Reply with quote

i checked the ATOM feed with the validator & shortlinks enabled and get then "Self reference doesn't match document location". With shortlinks disabled the feed is valid.

Quote:
Example: Only registered users can see links on this board! Get registered or login!

Validator Output:
<link rel="self" type="application/atom+xml" href="http://www.my.domain/feeds.html?amp;fid=11&amp;type=ATOM" />


another Question is with the RSS2.0 Feed if i check it i get
Quote:
Example: Only registered users can see links on this board! Get registered or login!

Validator Output:
Missing atom:link with rel="self"


and the last Question is about the author section in Atom feeds, Only registered users can see links on this board! Get registered or login! do i have to change this and if so, where?

thanks Brujo


Last edited by Brujo on Sat Apr 12, 2008 9:05 am; edited 1 time in total 
View user's profile Send private message
kguske
Site Admin


Joined: Jun 04, 2004
Posts: 6383

PostPosted: Sat Apr 12, 2008 8:38 am Reply with quote

We may need to build some logic into nukeFEED to address shortlinks, but I'm not sure when that will happen.

Not sure why the validator would give a message regarding ATOM for an RSS 2.0 feed. Does that happen with shortlinks off?

Regarding the author section, I'd suggest that changing that would open the door for spam. I believe it's only there for validation, but I haven't tested not using it, either.

_________________
I google, therefore I exist...
Only registered users can see links on this board! Get registered or login!
 
View user's profile Send private message
montego
Site Admin


Joined: Aug 29, 2004
Posts: 9453
Location: Arizona

PostPosted: Sat Apr 12, 2008 9:04 am Reply with quote

Brujo/kguske,

I will look into the ShortLinks aspect of this. I have this working - I think - on my sites so I want to understand better as to what is going on there. I may be able to fix.

This is RavenNuke 2.20.x right?

_________________
Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website
Brujo
PostPosted: Sat Apr 12, 2008 10:09 am Reply with quote

@montego - i have rn 2.20.01
if you take a look, i think in nukeFEED.php the $syndicationURL have to be different if shortlinks is enabled

@kguske - missing atom: is independent from shortlinks
i checked it with Only registered users can see links on this board! Get registered or login! & validator.w3.org/feed/ with the same result that indeed the feed is valid but with this recomendation
Quote:
This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations. line xy, column 4: Missing atom:link with rel="self"

and i found this: Only registered users can see links on this board! Get registered or login!


btw i did a look to backend.php

Code:
if (isset($tnsl_bUseShortLinks) && $tnsl_bUseShortLinks) {

        header('Location: http://'.$host.$uri.'/feeds-1-rss20.xml');
} else {
        header('Location: http://'.$host.$uri.'/feeds-1-rss20.xml');
}
this code assume that fid=1 is existing and that nobody deleted this feed like i did in the feed module Very Happy for my OK i fixed that, but as an Idea, Users should not be able to delete Feed 1 or the backend is gone..

Brujo
 
montego
PostPosted: Fri Apr 25, 2008 1:24 pm Reply with quote

Brujo, btw, I am looking at the ShortLinks issue now and I am pretty sure that I can fix the validation error. It is definitely in the "link rel" at the top.

It does not seem to impact the usability of the feed, but it does affect its validation. I'll let you know what I come up with.
 
montego
PostPosted: Fri Apr 25, 2008 1:33 pm Reply with quote

Ok, it turns out to have been an inconsistency in the use of ATOM1.0 vs ATOM. Here is the fix:

=== OPEN ===

ShortLinks/GT-Feeds.php

=== REPLACE ===

Replace the entire $urlin/$urlout with the following:

Code:


$urlin = array(
'"modules.php\?name=Feeds&amp;fid=([0-9]*)&amp;type=HTML"',
'"modules.php\?name=Feeds&amp;fid=([0-9]*)&amp;type=RSS([0-9]{1})\.([0-9]{1,2})"',
'"modules.php\?name=Feeds&amp;fid=([0-9]*)&amp;type=ATOM([0-9]{1})\.([0-9]{1,2})"',
'"modules.php\?name=Feeds&amp;fid=([0-9]*)&amp;type=ATOM"',
'"modules.php\?name=Feeds&amp;op=map&amp;type=OPML"',
'"modules.php\?name=Forums&amp;file=viewtopic&amp;t=([0-9]*)"',
'"modules.php\?name=News&amp;file=article&amp;sid=([0-9]*)"',
'"modules.php\?name=Downloads&amp;op=getit&amp;lid=([0-9]*)"',
'"modules.php\?name=Downloads&amp;d_op=getit&amp;lid=([0-9]*)"', // <-- For NSN GR Downloads
'"modules.php\?name=Content&amp;pa=showpage&amp;pid=([0-9]*)"',
'"modules.php\?name=Web_Links&amp;l_op=viewlinkdetails&amp;lid=([0-9]*)"',
'"modules.php\?name=Feeds"'
);

$urlout = array(
'feeds-\\1.html',
'feeds-\\1-rss\\2\\3.xml',
'feeds-\\1-atom\\2\\3.xml',
'feeds-\\1-atom10.xml',
'feeds-map-opml.xml',
'ftopict-\\1.html',
'article\\1.html',
'download-file-\\1.html',
'download-file-\\1.html', // <-- For NSN GR Downloads
'content-\\1.html',
'viewlinkdetails-\\1.html',
'feeds.html'
);


=== FINISH ===

The Atom feed now validates on my own site with this change.

kguske, it was a difference in the use of atom version number being missing in the link rel statement at the top. You use ATOM1.0 in most other places except at the top.
 
Brujo
PostPosted: Fri Apr 25, 2008 11:28 pm Reply with quote

@montego
perfect, works also for me no more validation issue with ATOM

btw. have someone a idea for the RSS recomendation "This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations. line xy, column 4: Missing atom:link with rel="self"
 
kguske
PostPosted: Sat Apr 26, 2008 7:22 am Reply with quote

Thanks, Brujo. I'll take a look.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> nukeFeed/FeedCreator

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©