Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Bug Fixes
Author Message
64bitguy
The Mouse Is Extension Of Arm


Joined: Mar 06, 2004
Posts: 1159
Location: Sanbornton, NH USA

PostPosted: Tue Apr 27, 2004 10:40 am Reply with quote

Is anyone working on phpbb port? In my reworking the "Your_Account" module, I have run into what looks like a large number of phpbb coding bugs.

I've also noticed a great deal of bad header calls.

I'm pretty new to MySQL and PHP, but it seems to me that everywhere after the first header calls at the top of the files, other header calls within the files should be replaced by redirect).

For example: in group_cp

Code:
$is_moderator = FALSE;


if ( isset($HTTP_POST_VARS['groupstatus']) && $group_id )
{
        if ( !$userdata['session_logged_in'] )
        {
                header($header_location . append_sid("login.$phpEx?redirect=groupcp.$phpEx&" . POST_GROUPS_URL . "=$group_id", true));
                exit;


Shouldn't this actually read:
Code:
$is_moderator = FALSE;


if ( isset($HTTP_POST_VARS['groupstatus']) && $group_id )
{
   if ( !$userdata['session_logged_in'] )
   {
      redirect(append_sid("login.$phpEx?redirect=groupcp.$phpEx&" . POST_GROUPS_URL . "=$group_id", true));


Next, I've seen people suggest to correct the problem to create an .htaccess file with the statement output_buffering = On. To be honest, isn't this just covering up the problem instead of fixing it? My attempt to apply this fix results in my site giving 500 errors.

Is it me or is it the code?

Thanks

_________________
Steph Benoit Only registered users can see links on this board! Get registered or login!
1CMS, 100% Section 508 and W3C XHTML/CSS Compliant (Truly) 
View user's profile Send private message Visit poster's website
chatserv
Member Emeritus


Joined: May 02, 2003
Posts: 1389
Location: Puerto Rico

PostPosted: Tue Apr 27, 2004 4:34 pm Reply with quote

I would think that one would be better handled by the phpbb group as it is original code.
 
View user's profile Send private message Visit poster's website
64bitguy
PostPosted: Tue Apr 27, 2004 7:50 pm Reply with quote

Upon downloading phpbb and comparing some of the code, it looks like these problems only exist in the port.
 
chatserv
PostPosted: Tue Apr 27, 2004 8:00 pm Reply with quote

If the code you posted above is only part of the port then i must have been there since the first port, anyway try what you suggested to see if it gets rid of the problem you were having.
 
sixonetonoffun
Spouse Contemplates Divorce


Joined: Jan 02, 2003
Posts: 2496

PostPosted: Tue Apr 27, 2004 8:42 pm Reply with quote

What is the problem? The good ole headers already sent by output at blah blah blah? I've only found that one where there is a cookie involved. Header location is just a redirect probably is from the original port Doesn't phpbb use a complex little gaggle of code to check the server environment then choose what method to redirect based on the server env?
 
View user's profile Send private message
chatserv
PostPosted: Tue Apr 27, 2004 8:49 pm Reply with quote

Truth is the last few versions of the port have only been released as upgrade patches, i have mentioned this a few times, maybe it's time i sit down and re-port the d*** thing, i think it's worth it. Razz
 
sixonetonoffun
PostPosted: Tue Apr 27, 2004 8:59 pm Reply with quote

Yikes wait for them to hit the big bang version. Twisted Evil
 
chatserv
PostPosted: Tue Apr 27, 2004 9:08 pm Reply with quote

I would imagine they will (or one of the mod authors) release a changes file, else all users that have modded their forums to death will be in pain so it still might be worth the extra effort.
 
Raven
Site Admin/Owner


Joined: Aug 27, 2002
Posts: 17086

PostPosted: Tue Apr 27, 2004 10:33 pm Reply with quote

And FB is doing away with phpbb in his next release.
 
View user's profile Send private message
chatserv
PostPosted: Tue Apr 27, 2004 10:44 pm Reply with quote

I have no problems with that actually, i don't plan to drop phpBB on my sites.
 
Guardian2003
Site Admin


Joined: Aug 28, 2003
Posts: 6793
Location: Ha Noi, Viet Nam

PostPosted: Thu Apr 29, 2004 10:36 am Reply with quote

Personally, I think a report is overdue.
Perhaps we can finally get rid of that pesky avatar problem and finally get some cohesion between Your Account and Profile?

FB is dropping phpBB from the core code? Woo- hoo, that means we will have a number of files that don't have to fixed!
 
View user's profile Send private message Send e-mail
chatserv
PostPosted: Thu Apr 29, 2004 10:54 am Reply with quote

And new ones will be added.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Bug Fixes

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©