Minor bug in banned IP list [FIX]

Posted: Tue Feb 20, 2007 4:54 pm

Hi

Its a very minor bug.

From the Banned IP list, select view and the banned IP details page is displayed in a new window/tab. This is fine but the [back] link will obviously not work.

1 solution would be to delete the [back] link but I prefer to change the target of the view link.

OPEN admin/modules/nukesentinel/ABBlockedIP.php

FIND

Code:

    echo "href='".$admin_file.".php?op=ABBlockedIPView&amp;xIPs=".$getIPs['ip_addr']."' target='_blank'><img src='images/nukesentinel/view.png' border='0' alt='"._AB_VIEW."' title='"._AB_VIEW."' height='16' width='16' /></a>&nbsp;<a ";

REPLACE WITH

Code:

    echo "href='".$admin_file.".php?op=ABBlockedIPView&amp;xIPs=".$getIPs['ip_addr']."'><img src='images/nukesentinel/view.png' border='0' alt='"._AB_VIEW."' title='"._AB_VIEW."' height='16' width='16' /></a>&nbsp;<a ";

Regards

Martyn

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Thank you. I will forward this to Bob.

Posted: Thu Mar 01, 2007 1:11 am

Reason for putting a target on it was so it would open a new window without losing your place in the listing, okay I lose my place alot Wink

It can be removed but I would kinda like to put it to a vote of all the NS users that visit here. That way it will be there or not there by the majority rule so to speak.

Posted: Thu Mar 01, 2007 3:50 am

I would have to agree with Bob, I would prefer it to open in a new window.

Posted: Thu Mar 01, 2007 3:54 am

Hi

I vote for losing the target, and for all like bob that "lose their place alot Wink

" there is always the right mouse click>open in new window/tab.

Regards

Martyn

Posted: Thu Mar 01, 2007 7:55 am

I also prefer to have it open in a new window.

Posted: Thu Mar 01, 2007 8:55 am

Looks like the odds are against me, the big guns are against me boxing

Looks like the solution had better be replace the back link with a close window link.

Posted: Fri Mar 02, 2007 6:19 am

lol...netgoodies, continue the battle.....look at David and Goliath.....take on the "big boys" ROTFL