Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Themes
Author Message
guidyy
Worker
Worker


Joined: Nov 22, 2004
Posts: 208
Location: Italy

PostPosted: Wed Apr 12, 2006 12:34 pm Reply with quote

Ok , i dont know why, but i can't have the your account module validate HTML 4.01
I'm using ravennuke 2.02 but even with fisubice theme I get 11 errors and 64 warnings. (warnings are from sommaire parametrable)
The errors are:
Unexpected </form>
Unexpected </font>
Missing </font>
repeated several times

Funny, this site says 0 erros and 3 warnings.
All the rest of my site is just fine.
Is "Your Account" on this site different from the one in the distribution?
Guido
 
View user's profile Send private message Visit poster's website MSN Messenger
spottedhog
Regular
Regular


Joined: Jun 02, 2004
Posts: 88

PostPosted: Thu Apr 13, 2006 9:33 am Reply with quote

After blazing thru all the original 7.6 code, I found a lot of what you are seeing. Generally if you get those errors, there is not a starting tag to correspond with those ending tags. Missing would imply that there is not a corresponding ending tag to the start tag.

Some of the issue may also be with what order the closing tags are placed in the code. The closing tags must be placed in exact reverse order of the opening tags.... mirror image so to speak.

....not sure if the above is your problem, but I did find all of that in the nuke code.
 
View user's profile Send private message Visit poster's website
guidyy
PostPosted: Thu Apr 13, 2006 1:18 pm Reply with quote

Yes, the your account code is rather messed up..
Most of the errors were on the navbar.php (there was a orphan </form> some random <center> and some missing closing tags)
but the most common problem (not only into Your account, but everywhere) is with <font class="content"> this tag is invalid before <tables>, inside paragraphs etc.
If you use the Wysiwyg editor, every piece of content you write, will make the page 401 invalid just because of the <font>.
Another problem very common is with <form>: I found <table><form blah blah><tr><td>input= blah blah</td></tr></form></table> that will Never validate Rolling Eyes
Too bad the problem is deep inside of php-nuke, so every upgrade is a pain in da butt.... (hours of file compare to fix it all)
Wonder when that FB guy, will start to listen.....

Guido
 
montego
Site Admin


Joined: Aug 29, 2004
Posts: 9456
Location: Arizona

PostPosted: Fri Apr 14, 2006 9:48 am Reply with quote

Quote:

Wonder when that FB guy, will start to listen.....


Do not hold your breath...

We are on our own. Others have corrected the code (64bitguy), but have not released it, and others have tried as well. You are correct, it makes every new patch that much more difficult to deal with.

No solutions, just answers... Laughing

_________________
Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website
guidyy
PostPosted: Fri Apr 14, 2006 12:14 pm Reply with quote

Well, my "new" yummyfood.net will be 401 valid every where (except all the admin area)
I'm still testing it on my local machine, but it's going pretty good.
I'm waiting the latest rn76 to go live.
what did i do?
messed up with my main theme (sunset)
(deleted <font class="content"> in several places so it doesnt conflict with the HTML editor.
moved almost everything on the style.css (I merged style.css and forums.css)
Deleted everything related to css from the overallheader.tpl: now I do not have the double <head> anymore when displaying forums
changed news/index.php
changed news/comment.php (there where a </form> too much)
changed your_account/index.php and navbar.php (again unfinished tags or redundant tags>
changed encyclopedia/index.php (wrong nesting as usual)
in mainfile.php i changed <font class="content> to class="title" for modules titles (that's only cosmetic stuff but it looks better imho)
changed footer.php (dropped font class="footmsg"> so i can use <div> and
<table>. Created CSS elements for footer.
changed weblinks redirect from 302 moved temporarily to 301 moved permanently
For better SEO I still need to fix encyclopedia to go to a custom 404.php page when an encyclopedia or a term has been removed.
Same for inactive modules. (instead of "sorry this module isn't active" goto 404.php)
The problem is: my php skills are close to zero... Very Happy
Guido
 
montego
PostPosted: Fri Apr 14, 2006 12:28 pm Reply with quote

Well, it sounds like your skills are better than you think. Wink Not sure yet whether we are going to focus on W3C compliance with RN76 2.10.00 release... I think it to be a good idea, but with it comes alot of on-going work. Keep an eye on the RavenNuke76 Announcements and maybe it will be "in scope".
 
guidyy
PostPosted: Fri Apr 14, 2006 12:51 pm Reply with quote

Hell! my goal is to have a better ranking than foodnetwork with 1/1,000,000 of their budget LOL! so i'm trying everything Very Happy

If you want, i can send my files, so you can diff and see what's wrong (beside my coding).
Guido
 
montego
PostPosted: Fri Apr 14, 2006 2:10 pm Reply with quote

No need... I've seen the W3C validation results... UGLY! Laughing
 
daemon
Worker
Worker


Joined: Jan 07, 2005
Posts: 163

PostPosted: Fri Apr 14, 2006 4:12 pm Reply with quote

think everyone needs to come up with a standard theme css and template so that we can convert all themes to it rather than just make "our" theme compliant, we also need theme designers to follow this standardized set. As Raven said before its a challenge but if we could make a default css and then recoded the themes, we could offer the entire package. Smile

_________________
Si vis pacem, bellum paratum Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website AIM Address
montego
PostPosted: Fri Apr 14, 2006 4:49 pm Reply with quote

daemon, not quite. Themes are relatively "easy" to make W3C compliant. The problem is that the core nuke code that also renders HTML (through "echo" and "print" statements) in many cases is not compliant. In addition, nuke does nothing to ensure the news articles and other submissions from others is compliant. So, you can have a compliant theme, such as the fisubice theme distributed with RavenNuke76, but your nuke site may not be.
 
guidyy
PostPosted: Sat Apr 29, 2006 1:46 am Reply with quote

If you give your users a very basic toolbar for the FCK editor bold ,italic, list, url, and couple of font sizes, 99% of posts will be 4.01.
Some problems may come with special characters but not so much..
of course you need to get rid of <font class=content> in your theme.
Guido
 
montego
PostPosted: Sun Apr 30, 2006 9:18 am Reply with quote

guidyy, excellent advice! Thank you.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Themes

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©