Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Ravens PHP Scripts And Web Hosting Forum Index -> Raven's RavenNuke(tm) v2.02.02 Distro
Author Message
benson
Worker
Worker


Joined: May 15, 2004
Posts: 119
Location: Germany

PostPosted: Fri Apr 21, 2006 4:20 am Reply with quote

Hello,
after update the Recommend_Us is not working correctly anymore:
If I click to that module the first 2 fields are filled with my user data, that's ok, but if I press send without adding a friends name or address, the module is sending (or it says it is sending ...).
Try to clear all fields, it shows alway successful sending ...

regards, Benson
 
View user's profile Send private message Visit poster's website
Susann
Moderator


Joined: Dec 19, 2004
Posts: 3191
Location: Germany:Moderator German NukeSentinel Support

PostPosted: Fri Apr 21, 2006 5:57 am Reply with quote

Thanks for the information. Please could you try it again but add the last line from the lang-english.php into the lang-german.php
Code:


define("_RU_NO","no");
 
View user's profile Send private message
montego
Site Admin


Joined: Aug 29, 2004
Posts: 9449
Location: Arizona

PostPosted: Fri Apr 21, 2006 7:49 am Reply with quote

Is this the latest 2.02.02 release or earlier?

_________________
Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website
Susann
PostPosted: Fri Apr 21, 2006 8:19 am Reply with quote

The earlier version was slightly different. So it´s in this release and upgrade patch.
The line is only in the Recommend-Us/language/lang-english.php file definend. I would like to know from Benson if this fixed his problem completely.


Last edited by Susann on Fri Apr 21, 2006 8:31 am; edited 1 time in total 
montego
PostPosted: Fri Apr 21, 2006 8:23 am Reply with quote

Ok. I am moving to the appropriate Forum then so we can track better.
 
benson
PostPosted: Fri Apr 21, 2006 10:06 am Reply with quote

Hi,
it is the newes version and the addition in the language file seams to work ! Thanks!

Regards, Norbert
 
Susann
PostPosted: Fri Apr 21, 2006 6:36 pm Reply with quote

Thank you for your feedback.
 
Raven
Site Admin/Owner


Joined: Aug 27, 2002
Posts: 17077

PostPosted: Fri Apr 21, 2006 9:57 pm Reply with quote

See this post for the complete solution: Only registered users can see links on this board! Get registered or login!
 
View user's profile Send private message
benson
PostPosted: Sat Apr 22, 2006 12:29 am Reply with quote

Hello,
since I am note allowed to post in the other thread, I will ask it here.

What is the reason for defining $RU_NO = _RU_NO; ?
For me it makes no difference if my php script calculates in english e.g. if ($send != "no") or in german e.g. if ($send != "nein") Very Happy? Therefor it makes no sence to me to define that variable in the language file ... It should also work if we change all $RU_NO back to 'no' or '0' ? Than no language files have to be changed.
Regards, Benson Question
 
Raven
PostPosted: Sat Apr 22, 2006 12:45 am Reply with quote

You cannot compare $send != _RU_NU which means each language would have to hardcode no, nein, nada, etc. So, to make it universal with no hard coding, you have to set a $variable = CONSTANT and then do the compare. You, of all people, are now condoning the hard coding of words in scripts instead of a language file killing me I find that rather hypocritical, wouldn't you say Wink, since your posts of late are hammering us about moving hard coded terms to the language files Laughing.
 
benson
PostPosted: Sat Apr 22, 2006 1:04 am Reply with quote

Hello Raven,
you are right! We, the non english ones, do have problems if text is hardcoded. We can change it, but the next update will overwrite it ...

In that Recommend_Us module the _RU_NO is only used to calculate internal rules. The text (no, nein, nada, etc.) is not shown anywhere to the user, just to the php interpreter Smile And I think apache is not very interested in no, nein, nada etc .... ?

So, sorry for my problems to explain it corretly, I just wanted to give you the hint to avoid language file changes for all languages if they are no neccessary (as I think).

P.S.: Please keap on moving hardcoded terms into the language files Very Happy
 
Raven
PostPosted: Sat Apr 22, 2006 1:12 am Reply with quote

This one IS necessary to remove hard coding from the index file. There is no other way.
 
Display posts from previous:       
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Ravens PHP Scripts And Web Hosting Forum Index -> Raven's RavenNuke(tm) v2.02.02 Distro

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©