Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Bug Fixes
Author Message
Andrzej
Hangin' Around


Joined: Jan 22, 2004
Posts: 31

PostPosted: Mon Sep 06, 2004 10:47 am Reply with quote

I have a problem with 6.5. The same is with original distro and the patched one.

When I add a comment to News (doesn't depend - both plain text and html) when I insert:
Code:
Czytaj: <a href=<a href=http://pawica.net><u>TRATATATATATA</u></a>

In the preview it's OK, when I post it I get such a linkadress:
Code:
http://pawica.nettitle='http//pawica.net'

which I have to correct in the database.

Anybody can help? Crying or Very sad

Andrzej
 
View user's profile Send private message
Raven
Site Admin/Owner


Joined: Aug 27, 2002
Posts: 17077

PostPosted: Mon Sep 06, 2004 11:35 am Reply with quote

Do you really have?
Code:
Czytaj: <a href=<a href=http://pawica.net><u>TRATATATATATA</u></a>

If so, it should be
Code:
Czytaj: <a href="http://pawica.net"><u>TRATATATATATA</u></a>
 
View user's profile Send private message
Andrzej
PostPosted: Mon Sep 06, 2004 11:54 am Reply with quote

Yes you a right, but I wrote only the link, that I see in the browser adress bar after clicking on the link (and the error message of course)

It looks like in the comment:
TRATATATATATA [pawica.net]

but the adress under this text is Only registered users can see links on this board! Get registered or login!

After looking in the preview it's OK, then it makes sth like that messraven

Andrzej

PS I've made such a test comment on this site, and there is the same effect. Look: Only registered users can see links on this board! Get registered or login!
 
Raven
PostPosted: Mon Sep 06, 2004 12:02 pm Reply with quote

I just did a test comment with a hyperlink and it worked perfectly. Please post the code here as a code block to show me how you are typing it.
 
Andrzej
PostPosted: Tue Sep 07, 2004 12:25 am Reply with quote

I type it :
Code:


Czytaj: <a href=http://www.prawica.net><u>Prawica.net</u></a>


I did it in this way in your news. Did you see?

Andrzej
 
Raven
PostPosted: Tue Sep 07, 2004 4:11 am Reply with quote

Yes, it is an error and I will look further into it. I have no answer at this time. Are you using GT or NG?
 
Raven
PostPosted: Tue Sep 07, 2004 6:36 am Reply with quote

The error is in modules/News/comments.php in the function format_url(). This line is the line that is in error. I will be testing a fix as soon as I can.
Code:
       $comment = ereg_replace(">$links[$i]</a>", "title='$hrefs[$i]'> $links[$i]</a>$href", $comment);
 
Raven
PostPosted: Tue Sep 07, 2004 6:51 am Reply with quote

Replace
Code:
      $comment = ereg_replace(">$links[$i]</a>", "title='$hrefs[$i]'> $links[$i]</a>$href", $comment);

with
Code:
       $comment = ereg_replace(">$links[$i]</a>", " title='$hrefs[$i]'> $links[$i]</a>$href", $comment);
 
Andrzej
PostPosted: Tue Sep 07, 2004 7:45 am Reply with quote

Thank yuo Raven Very Happy

You are great !
RavensScripts

It works! You are making PHPNuke better and better!

What do you think - is it possible to make such a script in comments.php, that the user, who only pastes link - like that:
Code:


Read:
http://www.wyborcza.pl/howto.html

(a lot of non-expirienced do it) to make it live? When he posts it in the plain text mode? Now it is only a text. Could it be in the comment clickable?

Thanks again

Andrzej
PS. But is it possible, that this error is still present from version 6.5???
Bang Head
 
Andrzej
PostPosted: Wed Oct 20, 2004 9:38 am Reply with quote

The same change you need to do in comments.php on surveys module

Andrzej
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Bug Fixes

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©