Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> NSN Gr Downloads - a.k.a NukeDepository
Author Message
hicuxunicorniobestbuildpc
Life Cycles Becoming CPU Cycles


Joined: Aug 13, 2009
Posts: 967
Location: Netherland

PostPosted: Sat Aug 11, 2012 10:00 am Reply with quote

Hi Guys, I wonder if anyone can help me to solve a validation error I have on this mod.

Code:
      OpenTable();

      //tags cloud by unicornio
      function otoTag($tag,$link,$en_tagi=10,$en_tago=18) {
$renk='#'.dechex(rand(1,16)).dechex(rand(1,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16));
$boy=rand($en_tagi,$en_tago);
echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>';
}


$target=$db->sql_query("SELECT lid,title FROM ".$prefix."_nsngd_downloads ORDER BY rand() limit 50");
while ($sonic=$db->sql_fetchrow($target))
     {
echo otoTag($sonic[title],'modules.php?name=Downloads&d_op=getit&lid='.$sonic[lid]);
}
//tags cloud
CloseTable();


error I am getting is from this part.
Code:
echo '<a href="'.$link.'" 

style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>'


The mod works perfect but I just need a little help to know where I can validate this part above. This is the warning.

Warning: <a> proprietary attribute "tag"
The tag contains an attribute that is proprietary to Netscape or Internet Explorer.

Sad In my eyes I don't see any problem...
 
View user's profile Send private message Visit poster's website
neralex
The Mouse Is Extension Of Arm


Joined: Aug 22, 2007
Posts: 1328
Location: Germany

PostPosted: Sat Aug 11, 2012 10:37 am Reply with quote

quick & shortly: "tag" is not an attribute of the a tag! perhaps you mean title?!
 
View user's profile Send private message
hicuxunicorniobestbuildpc
PostPosted: Sat Aug 11, 2012 10:48 am Reply with quote

Neralex, thanks for pushing me to the right direction! Very Happy


Last edited by hicuxunicorniobestbuildpc on Sat Aug 11, 2012 11:44 am; edited 1 time in total 
neralex
PostPosted: Sat Aug 11, 2012 10:50 am Reply with quote

Only registered users can see links on this board! Get registered or login!
 
hicuxunicorniobestbuildpc
PostPosted: Sat Aug 11, 2012 11:01 am Reply with quote

This is what I did so far

Code:
echo '<a id="" href="'.$link.'"

style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>';
}


but I get the same error Shocked
 
nuken
RavenNuke(tm) Development Team


Joined: Mar 11, 2007
Posts: 2024
Location: North Carolina

PostPosted: Sat Aug 11, 2012 11:12 am Reply with quote

Your link to the download is wrong too. should be op and not d_op.

_________________
Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Send e-mail Visit poster's website
hicuxunicorniobestbuildpc
PostPosted: Sat Aug 11, 2012 11:34 am Reply with quote

Finally I fix it. I was so easy. thanks guy. I do know u want me to learn but sometimes u are a little bit too hard. Let me know if it is correct.

Code:
echo '<a href="'.$link.'"

style="font-size: ' . $boy . 'px;color:'.$renk.'">' . $tag . ' </a>';
}



Now it is validated Very Happy

I didn't want to share the whole mode until I get it validated.

Here we go! This is a very easy mod and beautiful tags cloud.

Open your ftp

modules/Downloads/public/index.php

Open index.php

Search for at the botton

Code:
CloseTable();

include_once 'footer.php';


Replace with

Code:
CloseTable();

      OpenTable();
      //tags cloud by unicornio
      function otoTag($tag,$link,$en_tagi=10,$en_tago=18) {
$renk='#'.dechex(rand(1,16)).dechex(rand(1,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16));
$boy=rand($en_tagi,$en_tago);
echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'">' . $tag . ' </a>';
}

$target=$db->sql_query("SELECT lid,title FROM ".$prefix."_nsngd_downloads ORDER BY rand() limit 50");
while ($sonic=$db->sql_fetchrow($target))
     {
echo otoTag($sonic[title],'modules.php?name=Downloads&amp;op=getit&amp;lid='.$sonic[lid]);
}
//tags cloud
CloseTable();
include_once 'footer.php';


Note: This mod is for RavenNuke 2.50 Download module from Montego. If you have any other download module could be easy too.

Very Happy If you think you can make it better, please share it with us.
 
neralex
PostPosted: Sun Aug 12, 2012 3:36 pm Reply with quote

I think a tag cloud is not needed for the download module but this only my opinion.
 
hicuxunicorniobestbuildpc
PostPosted: Sun Aug 12, 2012 4:57 pm Reply with quote

neralex, I think tag cloud for the download module is pretty good. We have tag cloud for the news too. Image you have 200 topics and with tag cloud you can find what u forgot or what u didn't see yourself. It is like the supermarket. Everyday they change articles so the next time you will find another product and so on. It is marketing and beautiful. It is just my opinion, maybe you are right.
 
neralex
PostPosted: Mon Aug 13, 2012 5:37 am Reply with quote

Articles and downloads are two completely different content types. One has nothing to do with the other. Tags of different content types in the same cloud makes no sense for me.
 
Susann
Moderator


Joined: Dec 19, 2004
Posts: 3191
Location: Germany:Moderator German NukeSentinel Support

PostPosted: Mon Aug 13, 2012 4:35 pm Reply with quote

Quote:
It is marketing and beautiful


No, you have to be very carefully by using tagclouds and keyword stuffing in this way from Seo point of view.

Maybe rel="nofollow" will help but I would not use a tagcloud in my downloadsection because its not needed.
 
View user's profile Send private message
kguske
Site Admin


Joined: Jun 04, 2004
Posts: 6383

PostPosted: Tue Aug 21, 2012 8:32 am Reply with quote

Susann, definitely agree that tag clouds should be used carefully, if at all. What are your thoughts on using tag clouds on multilingual sites?

_________________
I google, therefore I exist...
Only registered users can see links on this board! Get registered or login!
 
View user's profile Send private message
Susann
PostPosted: Tue Aug 21, 2012 10:02 am Reply with quote

Sounds like a very interesting feature since all sites have normally worldwide traffic but the rules are more or less the same. In any event it should be used very carefully.
Beside this the hype with tag clouds is since a long time over I believe.
And if Google doesn´t like your site anymore you will have a hard time to get back the previous status.
 
kguske
PostPosted: Tue Aug 21, 2012 10:29 am Reply with quote

I agree and definitely appreciate your input on these subjects as your international perspective is very valuable.

IMO, the "wow" factor of tag clouds is short lived, probably because they don't really help visitors and because the SEO benefits are questionable.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> NSN Gr Downloads - a.k.a NukeDepository

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©