Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Themes
Author Message
mrix
Client


Joined: Dec 04, 2004
Posts: 757

PostPosted: Fri Jun 04, 2010 6:39 am Reply with quote

Hi I really love the menu and something I really wish to keep, I understand there are unfortunately issues with it.
Basically the menu does not work the way it should, all I have done is basically added links to all the forums which makes me think half the code within it does not really need to be there
Cheers
mrix Question
 
View user's profile Send private message Visit poster's website
mrix
PostPosted: Sat Jun 05, 2010 4:34 am Reply with quote

Hi there the contents of the block are here...

Code:
<?php


if ( !defined('BLOCK_FILE') ) {
    Header('Location: ../index.php');
    die();
}

global $prefix, $db, $admin, $user, $modlist, $dummy, $default_module;
$content = '';
$ThemeSel = get_theme();
$def_module = '';
if (file_exists('themes/'.$ThemeSel.'/module.php')) {
    include_once('themes/'.$ThemeSel.'/module.php');
    if (is_active($default_module) AND file_exists('modules/'.$default_module.'/index.php')) {
        $def_module = $default_module;
    } else {
        $def_module = '';
    }
}

//-------------MODIFY HERE TO CUSTOMIZE THE MENU------>
$image1 = "images/arrow.gif";          /* image path relative to public root*/
$image2 = "images/icon_select.gif";          /* image path relative to public root*/
$image3 = "images/oarrow.gif";          /* image path relative to public root*/

$row2show = "7";            /* "NUMBER YOU SELECT (default is 5)" = numbers of rows visible when block style */

define ("mSECTION1","General");         /* title Menu Section 1 */
define ("mSECTION2","Our Sponsors");         /* title Menu Section 2 */
define ("mSECTION3","Forums");         /* title Menu Section 3 */
define ("mSECTION4","Resources");   /* title Menu Section 4 */
define ("mSECTION5","Sea Fishing Tackle");         /* title Menu Section 5 */
define ("mSECTION6","Fishing Links");                /* title Menu Section 6 */
define ("mSECTION7","Admin");                /* title Menu Section 7 */
//--------END-----------END----------END------------>

$row = $db->sql_fetchrow($db->sql_query('SELECT main_module FROM '.$prefix.'_main'));
$main_module = $row['main_module'];
/* If the module doesn't exist, it will be removed from the database automaticaly */
$result2 = $db->sql_query('SELECT title FROM ' . $prefix . '_modules');
while ($row2 = $db->sql_fetchrow($result2)) {
    $title = stripslashes($row2['title']);
    $a = 0;
    $handle=opendir('modules');
   while (false !== ($file = readdir($handle))) {
      if ($file == $title) {
         $a = 1;
      }
   }   
    closedir($handle);
    if ($a == 0) {
        $db->sql_query('DELETE FROM '.$prefix.'_modules WHERE title=\''.$title.'\'');
    }
}

/* Now we make the Modules block with the correspondent links */
/* Menu Section 1 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>" .mSECTION1."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/\">Home</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/members.html\">Members List</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/account.html\">Your Account</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 2 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>" .mSECTION2."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/fishing-tackle.html\">Fishing Tackle Shops</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 3 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>" .mSECTION3."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/ftopict-45.html\">Important Rules</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-2.html\">General</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-3.html\">South</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-70.html\">South West</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-73.html\">South East</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-5.html\">East</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-4.html\">West</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-29.html\">North East</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-74.html\">North West</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-30.html\">Scotland</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-7.html\">Wales</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-69.html\">Ireland</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-68.html\">Isle of Wight</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-75.html\">Thames Estuary</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-81.html\">Humber Estuary</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-60.html\">Sea Fishing Rods</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-61.html\">Sea Fishing Reels</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-62.html\">Sea Fishing Lines</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-64.html\">Sea Fishing Baits</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-67.html\">Terminal Tackle</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-72.html\">Sea Fly Fishing</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-71.html\">Kayak Fishing</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-31.html\">Sea Fishing Tips</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-76.html\">Boat Owners</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-77.html\">Boat Fishing Tips</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-19.html\">International</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-18.html\">SeaFood Recipes</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/forum-54.html\">The Lounge</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 4 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>".mSECTION4."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/Fish_Pictures.html\">Sea Fish</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/nfsa-size-limits.html\">NFSA Size Limits</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/Fishing_Knots.html\">Sea Fishing Knots</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/Sea_Baits.html\">Sea Fishing Baits</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/rigs1.html\">Sea Fishing Rigs 1</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/rigs2.html\">Sea Fishing Rigs 2</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/rigs3.html\">Sea Fishing Rigs 3</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/fishing-tides-uk.html\">UK Tide Tables</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/weather-uk.html\">UK Weather</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/reviews.html\">Fishing Tackle Reviews</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 5 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>".mSECTION5."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-fishing-books.html\">Sea Fishing Books</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-fishing-reels.html\">Sea Fishing Reels</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-fishing-rods.html\">Sea Fishing Rods</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-fishing-lines.html\">Sea Fishing Lines</></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-fishing-videos.html\">Sea Fishing Videos</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/sea-combos.html\">Rod / Reel Deals</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/rigs-traces.html\">Ready Made Rigs</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 6 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>".mSECTION6."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/links.html\">Fishing Links</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/fishing-tackle.html\">Fishing Tackle Shops</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"http://www.fishingtackleauction.net\">Fishing Tackle Auction</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/fishing-webrings.html\">Fishing Webrings</a></TD></TR>\n";
$content .= "<TR $actionMenu''\"><TD class=\"row1\"><a href=\"/topsite/\"target=\"_blank\">Fishing Directory</a></TD></TR>\n";
$content .= "</TABLE>\n";
//$content .= "<HR noShade SIZE=1>\n"; /* <hr> to separate menu */

/* Menu Section 7 */
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\"><tr><TD class=\"info1\"><img src=$image2 BORDER=0><b>".mSECTION7."</b></td></tr></table>\n";
$content .= "<TABLE BORDER=0 CELLPADDING=0 CELLSPACING=0 WIDTH=\"100%\">\n";
$content .= "<TR$actionMenu''\"><TD class=\"row1\"><a href=\"mailto:mrix@sea-fishing.org\">Email Me</a></TD></TR>\n";
$content .= "</TABLE>\n";

?>



I am using the block as direct links and not really as the block was intended so I would of thought I dont need half of what there ???

Cheers all
mrix
 
Palbin
Site Admin


Joined: Mar 30, 2006
Posts: 2583
Location: Pittsburgh, Pennsylvania

PostPosted: Sat Jun 05, 2010 6:52 am Reply with quote

It doesn't look bad. The major thing I see is that none of those tags or attributes should be in capital letters.

_________________
"Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan. 
View user's profile Send private message
spasticdonkey
RavenNuke(tm) Development Team


Joined: Dec 02, 2006
Posts: 1693
Location: Texas, USA

PostPosted: Sat Jun 05, 2010 11:56 am Reply with quote

try this Wink

Code:
<?php

if ( !defined('BLOCK_FILE') ) {
    Header('Location: ../index.php');
    die();
}

global $prefix, $db, $admin, $user, $modlist, $dummy, $default_module;
$content = '';
$ThemeSel = get_theme();
$def_module = '';
if (file_exists('themes/'.$ThemeSel.'/module.php')) {
    include_once('themes/'.$ThemeSel.'/module.php');
    if (is_active($default_module) AND file_exists('modules/'.$default_module.'/index.php')) {
        $def_module = $default_module;
    } else {
        $def_module = '';
    }
}

$image1 = "images/arrow.gif";          /* image path relative to public root*/
$image2 = "images/icon_select.gif";          /* image path relative to public root*/
$image3 = "images/oarrow.gif";          /* image path relative to public root*/

$row2show = "7";            /* NUMBER YOU SELECT (default is 5) = numbers of rows visible when block style */

define ("mSECTION1","General");         /* title Menu Section 1 */
define ("mSECTION2","Our Sponsors");         /* title Menu Section 2 */
define ("mSECTION3","Forums");         /* title Menu Section 3 */
define ("mSECTION4","Resources");   /* title Menu Section 4 */
define ("mSECTION5","Sea Fishing Tackle");         /* title Menu Section 5 */
define ("mSECTION6","Fishing Links");                /* title Menu Section 6 */
define ("mSECTION7","Admin");                /* title Menu Section 7 */

$row = $db->sql_fetchrow($db->sql_query('SELECT main_module FROM '.$prefix.'_main'));
$main_module = $row['main_module'];
/* If the module doesn't exist, it will be removed from the database automaticaly */
$result2 = $db->sql_query('SELECT title FROM ' . $prefix . '_modules');
while ($row2 = $db->sql_fetchrow($result2)) {
    $title = stripslashes($row2['title']);
    $a = 0;
    $handle=opendir('modules');
   while (false !== ($file = readdir($handle))) {
      if ($file == $title) {
         $a = 1;
      }
   }   
    closedir($handle);
    if ($a == 0) {
        $db->sql_query('DELETE FROM '.$prefix.'_modules WHERE title=\''.$title.'\'');
    }
}

/* Now we make the Modules block with the correspondent links */
/* Menu Section 1 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>" .mSECTION1."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/\">Home</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/members.html\">Members List</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/account.html\">Your Account</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 2 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>" .mSECTION2."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/fishing-tackle.html\">Fishing Tackle Shops</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 3 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>" .mSECTION3."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/ftopict-45.html\">Important Rules</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-2.html\">General</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-3.html\">South</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-70.html\">South West</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-73.html\">South East</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-5.html\">East</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-4.html\">West</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-29.html\">North East</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-74.html\">North West</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-30.html\">Scotland</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-7.html\">Wales</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-69.html\">Ireland</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-68.html\">Isle of Wight</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-75.html\">Thames Estuary</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-81.html\">Humber Estuary</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-60.html\">Sea Fishing Rods</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-61.html\">Sea Fishing Reels</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-62.html\">Sea Fishing Lines</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-64.html\">Sea Fishing Baits</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-67.html\">Terminal Tackle</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-72.html\">Sea Fly Fishing</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-71.html\">Kayak Fishing</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-31.html\">Sea Fishing Tips</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-76.html\">Boat Owners</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-77.html\">Boat Fishing Tips</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-19.html\">International</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-18.html\">SeaFood Recipes</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/forum-54.html\">The Lounge</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 4 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>".mSECTION4."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/Fish_Pictures.html\">Sea Fish</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/nfsa-size-limits.html\">NFSA Size Limits</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/Fishing_Knots.html\">Sea Fishing Knots</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/Sea_Baits.html\">Sea Fishing Baits</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/rigs1.html\">Sea Fishing Rigs 1</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/rigs2.html\">Sea Fishing Rigs 2</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/rigs3.html\">Sea Fishing Rigs 3</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/fishing-tides-uk.html\">UK Tide Tables</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/weather-uk.html\">UK Weather</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/reviews.html\">Fishing Tackle Reviews</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 5 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>".mSECTION5."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-fishing-books.html\">Sea Fishing Books</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-fishing-reels.html\">Sea Fishing Reels</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-fishing-rods.html\">Sea Fishing Rods</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-fishing-lines.html\">Sea Fishing Lines</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-fishing-videos.html\">Sea Fishing Videos</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/sea-combos.html\">Rod / Reel Deals</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/rigs-traces.html\">Ready Made Rigs</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 6 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>".mSECTION6."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"/links.html\">Fishing Links</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/fishing-tackle.html\">Fishing Tackle Shops</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"http://www.fishingtackleauction.net\">Fishing Tackle Auction</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/fishing-webrings.html\">Fishing Webrings</a></td></tr>\n";
$content .= "<tr><td class=\"row1\"><a href=\"/topsite/\"target=\"_blank\">Fishing Directory</a></td></tr>\n";
$content .= "</table>\n";

/* Menu Section 7 */
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\"><tr><td class=\"info1\"><img src=\"$image2\" border=\"0\" /><b>".mSECTION7."</b></td></tr></table>\n";
$content .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" style=\"width:100%;\">\n";
$content .= "<tr><td class=\"row1\"><a href=\"mailto:mrix@sea-fishing.org\">Email Me</a></td></tr>\n";
$content .= "</table>\n";

?>
 
View user's profile Send private message Visit poster's website
mrix
PostPosted: Sat Jun 05, 2010 1:00 pm Reply with quote

Hi there guys thanks for those adjustments Cool
I have applied them and lost at least 100 errors Very Happy
Cheers and thanks
mrix
 
spasticdonkey
PostPosted: Sat Jun 05, 2010 1:07 pm Reply with quote

the user info block has some errors, try this one, but read the readme (after extracting as it's in html) Only registered users can see links on this board! Get registered or login!

the forums scrolling block uses alot of <br> tags instead of <br />
find/replace all <br> in that block to <br />
also find
<img src="themes/ClanMtS/forums/images/icon_minipost.gif" border="0" alt="">
and change to
<img src="themes/ClanMtS/forums/images/icon_minipost.gif" border="0" alt="" />

that will fix alot more Wink
 
mrix
PostPosted: Sat Jun 05, 2010 2:04 pm Reply with quote

Great stuff Cool Very Happy
I have now gone from over 400 errors to 191 Very Happy
Big thanks
mrix
 
mrix
PostPosted: Sat Jun 05, 2010 5:19 pm Reply with quote

I keep masses of these errors

Code:
 Line 603, Column 141: required attribute "alt" not specified

…ow1"><img src="themes/ClanMtS/forums/images/folder_new.gif" border="0" /[color=red]>[/color]</td>

The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.

Typical values for type are type="text/css" for <style> and type="text/javascript" for <script>.


Not sure what the validation is telling me? I added the colour tag as its highlighted red on that site.

Cheers
mrix
 
Raven
Site Admin/Owner


Joined: Aug 27, 2002
Posts: 17086

PostPosted: Sat Jun 05, 2010 6:05 pm Reply with quote

All "img" tags should have the "alt" attribute.

Change:
<img src="themes/ClanMtS/forums/images/folder_new.gif" border="0" />

To:
<img src="themes/ClanMtS/forums/images/folder_new.gif" border="0" alt="" />

Or Even Better:
<img src="themes/ClanMtS/forums/images/folder_new.gif" border="0" alt="New Folder" />
 
View user's profile Send private message
mrix
PostPosted: Sun Jun 06, 2010 3:07 am Reply with quote

My theme has hundreds of images so does that mean I should add some keyword text to every img ? would that be good SEO or would it be better just to add the tag ? or are you saying just add a tag anyway even if its not keyword related to the site and just the image file name?

Cheers and thanks
mrix
 
mrix
PostPosted: Sun Jun 06, 2010 6:35 am Reply with quote

Just checking through my forum scroll block and its full of errors Sad
Is anyone aware of a forum block scroll that is more compliant?
Cheers all
mrix
 
spasticdonkey
PostPosted: Sun Jun 06, 2010 7:34 am Reply with quote

mrix wrote:
Just checking through my forum scroll block and its full of errors Sad
Is anyone aware of a forum block scroll that is more compliant?
Cheers all
mrix

Only registered users can see links on this board! Get registered or login!

Quote:
My theme has hundreds of images so does that mean I should add some keyword text to every img ? would that be good SEO or would it be better just to add the tag ? or are you saying just add a tag anyway even if its not keyword related to the site and just the image file name?


I personally wouldn't worry too much about alt tags on every image, but they are a good idea for images used in navigation or that need some sort of additional info. You can also add a title tag which will show the tag on mouseover for browsers that don't do that for alt tags. For instance your main logo
before
<img height="104" width="421" alt="" src="themes/ClanMtS/images/header/ClanMts-hd_logo.gif">
after
<img height="104" width="421" alt="Sea fishing Sea Angling Resource" title="Sea fishing Sea Angling Resource" src="themes/ClanMtS/images/header/ClanMts-hd_logo.gif" />

It's debatable how much SEO value alt tags have these days, but they are a good idea for visually impaired visitors Wink
 
Raven
PostPosted: Sun Jun 06, 2010 11:11 am Reply with quote

But for people that suppress their images, for various reasons, the alt property is important. And, I believe but could be mistaken, screen readers utilize the alt property. Still, to be xhtml compliant, you should at least add the alt="" or alt=" " property Wink
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> Themes

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©