!!!!! osc2nuke Security Admin hole fix !!!!!

Posted: Sat Oct 17, 2009 10:06 am

Hello @ll,

If you use the osc2nuke modules, you have a security hole in the osc ACP.
Check this:

Go as Guest on your site, than put this after your domain in your browser:

/modules/catalog/admin/ (http//your_domain/modules/catalog/admin/)

This will redirect you to the osc Adminlogin Page. If you dont have an oscadmin and use only the nuke admin, you will have a security hole.

Everybody can now registered a oscadmin, because there are not in the osc Database.

Try This: Login as nukeadmin and go in your shop ACP

Now go back in the NukeACP and logout. Go on your site index and put /modules/catalog/admin/ after your Domain and press enter.
After this you are again in the ShopACP as Admin. Logout in the right corner on the top >> Logged in as: (Logoff) <<, now you are redircted on the admin loginpage and its call you:

No Admin in the Database ............. !!!!!

Now we fix the hole:

go in modules/catalog/admin and open with a editor the login.php and change the completely code with this code:

Code:

<?php


/*


  $Id: $





  osCommerce, Open Source E-Commerce Solutions


  http://www.oscommerce.com





  Copyright (c) 2007 osCommerce





  Released under the GNU General Public License


*/





  require('includes/application_top.php');





  $action = (isset($HTTP_GET_VARS['action']) ? $HTTP_GET_VARS['action'] : '');





  if (tep_not_null($action)) {


    switch ($action) {


      case 'logoff':


        tep_session_unregister('selected_box');


        tep_session_unregister('admin');


        tep_redirect(tep_href_link(FILENAME_DEFAULT));





        break;


    }


  }





tep_redirect('/');


 ?>

Save it and upload it on your Space.

Try again as Guest to go on the osc Admin Loginpage, and you are redirected to your index root.

Login as nuke Admin and try to go in your osc ACP its works for you and your admins but nobody can make an Admin in a empty osc Admin Database anymore.

Have a nice Day

Best Regards

Peter

Posted: Mon Oct 26, 2009 9:34 pm

Thank you for posting this.

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

I have made this a sticky Wink

Posted: Tue Oct 27, 2009 3:54 am

I have found the hole on the pragma port and my osc2nuke Version, too. Wink

Thanx for the sticky Smile

Best Regards

Peter