NSN Downloads not fully working...

webservant · Posted: Wed Mar 21, 2007 11:59 am

A while ago, I replaced Downloads with NSN Downloads, and had it working under an 0.4a GT. When I upgraded to RN 2.10 with Shortlinks, the NSN Downloads main page (download.html) works, but any links off of it go back to this page (download.html).

To resolve this, I went back to the GoogleTap directory and took the original GT-Downloads.php which had this in it:

Code:

$urlin = array(
"'(?<!/)modules.php\?name=Downloads&op=modifydownloadrequest&lid=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&op=NewDownloads&newdownloadshowdays=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&op=NewDownloadsDate&selectdate=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=Downloads&op=getit&lid=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&op=(MostPopular)&ratenum=([0-9]*)&ratetype=(num|percent)'",
"'(?<!/)modules.php\?name=Downloads&op=(NewDownloads|MostPopular)'",
"'(?<!/)modules.php\?name=Downloads&cid=([0-9]*)&orderby=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=Downloads&min=([0-9]*)&cid=([0-9]*))'",
"'(?<!/)modules.php\?name=Downloads&op=search&query=([/:\-\'{}()\,\._&a-zA-Z0-9+=]*)&min=([0-9]*)&orderby=([a-zA-Z0-9+]*)&show=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&op=search&query=([/:\-\'{}()\,\._&a-zA-Z0-9+= ]*)&orderby=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=Downloads&op=search'",
"'(?<!/)modules.php\?name=Downloads&op=gfx&random_num=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads'"
);

$urlout = array(
"download-mod-\\1.html",
"download-shownew-\\1.html",
"download-seldate-\\1.html",
"download-file-\\1.html",
"download-\\1-\\2-\\3.html",
"downloads-\\1.html",
"download-sort-\\1-orderby-\\2.html",
"download-paging-\\1-\\2.html",
"download-search-\\1-\\2-\\3-\\4.html",
"download-search-\\1-\\2.html",
"download-search.html",
"download-gfx-\\1.html",
"downloads-cat\\1.html",
"downloads.html"
);

And changed it to this (following Montego's lead):

Code:

$urlin = array(
'"(?<!/)modules.php\?name=Downloads&op=modifydownloadrequest&lid=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads&op=NewDownloads&newdownloadshowdays=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads&op=NewDownloadsDate&selectdate=([a-zA-Z0-9+]*)"',
'"(?<!/)modules.php\?name=Downloads&op=getit&lid=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads&op=(MostPopular)&ratenum=([0-9]*)&ratetype=(num|percent)"',
'"(?<!/)modules.php\?name=Downloads&op=(NewDownloads|MostPopular)"',
'"(?<!/)modules.php\?name=Downloads&cid=([0-9]*)&orderby=([a-zA-Z0-9+]*)"',
'"(?<!/)modules.php\?name=Downloads&min=([0-9]*)&cid=([0-9]*))"',
'"(?<!/)modules.php\?name=Downloads&op=search&query=([/:\-\'{}()\,\._&a-zA-Z0-9+=]*)&min=([0-9]*)&orderby=([a-zA-Z0-9+]*)&show=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads&op=search&query=([/:\-\'{}()\,\._&a-zA-Z0-9+= ]*)&orderby=([a-zA-Z0-9+]*)"',
'"(?<!/)modules.php\?name=Downloads&op=search"',
'"(?<!/)modules.php\?name=Downloads&op=gfx&random_num=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads&cid=([0-9]*)"',
'"(?<!/)modules.php\?name=Downloads"'
);

$urlout = array(
'download-mod-\\1.html',
'download-shownew-\\1.html',
'download-seldate-\\1.html',
'download-file-\\1.html',
'download-\\1-\\2-\\3.html',
'downloads-\\1.html',
'download-sort-\\1-orderby-\\2.html',
'download-paging-\\1-\\2.html',
'download-search-\\1-\\2-\\3-\\4.html',
'download-search-\\1-\\2.html',
'download-search.html',
'download-gfx-\\1.html',
'downloads-cat\\1.html',
'downloads.html'
);

Is this the correct solution, or is there a tweaked version to the Shortlinks supplied GT-Downloads.php that would be better?

montego · Posted: Thu Mar 22, 2007 6:04 am

webservant, you are correct, NSN Downloads is different than the standard PHP-Nuke downloads and I have the necessary tweaks as a separate download from my site:

Only registered users can see links on this board!
Get registered or login to the forums!

Regards,
montego

webservant · Posted: Thu Mar 22, 2007 3:33 pm

Thanks!

montego · Posted: Thu Mar 22, 2007 10:09 pm

I couldn't just make a simple ShortLinks variant as it requires a small code change to also work properly with the search. Hence, the separate download.

webservant · Posted: Fri Mar 23, 2007 4:57 am

I've applied the differences and it all works great! Thanks again!

montego · Posted: Fri Mar 23, 2007 6:22 am

Glad to hear it.

sixf00t4 · Regular Joined: Nov 05, 2006 Posts: 96

Thanks so much!!! Works like a charm!

Susann · Posted: Fri Oct 19, 2007 10:50 am

It doesn´t work like a charm there are still some issues with submit downloads and short links or such urls: downloads.html&min=10&cid=1 .
However, there are much more issues with that module but we have to be patient because Montego is the only who has taken over this module and its very time consuming to get this all fixed. I know this because I only tried to make it W3C valid and its still not 100 % valid.

montego · Posted: Sat Oct 20, 2007 4:51 pm

Yeah, sorry, it is next on the list after RN 2.20.00.