BB2Nuke 2.0.18 np - critical bug and fix

ToolBox · Regular Joined: Mar 16, 2005 Posts: 74

< this is a copy of the post in my dev. site forums >
Source Link:

Only registered users can see links on this board!
Get registered or login to the forums!

After upgrading BB2Nuke 2.0.17 by myself (without BB2Nuke 2.0.18 by chatserv), I compared the whole codes of mine with chatserv's great work of BB2Nuke 2.0.18 np.

Unfortunately, I found a critical bug. When you did not fix this bug, your forum topic can not move when you click on pagination numbers. Therefore, simply replace a fractional code block in viewtopic.php (phpBB2 stand-alone 2.0.18 has the exact same codes as below).

in MODification format:

Code:

#
# -------- [ OPEN ] -----------
#
<nuke-root>/modules/Forums/viewtopic.php

#
# -------- [ FIND ] -----------
#
//
// Decide how to order the post display
//
if ( !empty($HTTP_POST_VARS['postorder']) || !empty($HTTP_GET_VARS['postorder']) )
{
$post_order = (!empty($HTTP_POST_VARS['postorder'])) ? htmlspecialchars($HTTP_POST_VARS['postorder']) : htmlspecialchars($HTTP_GET_VARS['postorder']);
if (!eregi("^((asc)|(desc))$",$post_order) )
{
message_die(GENERAL_ERROR, 'Selected post order is not valid');
}
$post_time_order = ($post_order == "asc") ? "ASC" : "DESC";
}
else
{
$post_order = 'asc';
$post_time_order = 'ASC';
}

#
# --------- [ REAPLCE WITH ] ---------------
#
//
// Decide how to order the post display
//
if ( !empty($HTTP_POST_VARS['postorder']) || !empty($HTTP_GET_VARS['postorder']) )
{
$post_order = (!empty($HTTP_POST_VARS['postorder'])) ? htmlspecialchars($HTTP_POST_VARS['postorder']) : htmlspecialchars($HTTP_GET_VARS['postorder']);
$post_time_order = ($post_order == "asc") ? "ASC" : "DESC";
}
else
{
$post_order = 'asc';
$post_time_order = 'ASC';
}

#
# ----- [ EoM ] ----------
#

Other minor bugs found but they are trivail enough and do not bother BB2Nuke.

Once again, I always appreciate chatserv's great contribution.

P.S. : Raven, this place is irrelevant, please move this topic to a appropriate forum slots. Thank you.