PHP Web Host - Quality Web Hosting For All PHP Applications Just Great Software
  Login or Register
 • Home • Downloads • Your Account • Forums • 

View next topic
View previous topic


Google
 
Web RavenPHPScripts (This Site)
Post new topic   Reply to topic
Author Message
Guardian2003
Site Admin


Joined: Aug 28, 2003
Posts: 6373
Location: Vsetin, Czech Republic

PostPosted: Fri Apr 15, 2011 5:08 pm Reply with quote Back to top

Good point! I think forum code at least for RNYA was kept in seperate files and I'm pretty sure Members_List module has logic to detect if forums are installed and/or enabled, likewise for Journal. Not sure what else has a dependency on forums apart from Private Messages but that particular module actually comprised mostly of code/functionality extracted from core PHPBB 2.x (template engine, global $vars and forum tables) so strictly speaking, they should be thought of as one and the same (module) even though they appear seperately.
I did start a module a while back as a replacement for PM module that utilised only nuke_user table plus a seperate supporting table for the messages which I can dig out if anyone wants to play with it.
View user's profile Send private message Send e-mail Visit poster's website
fkelly
Moderator


Joined: Aug 30, 2005
Posts: 3186
Location: near Albany NY

PostPosted: Sun Apr 17, 2011 8:53 am Reply with quote Back to top

Sorry for delay in replying.
Raven wrote:
But, I thought we had resolved the Forum dependency. What have I missed?


I believe there are still many hard-coded dependencies. For instance, in saveactivate.php in /modules/Your_Account/public, we see code such as this. It's going to bomb if there is no /modules/Forums directory. Forums dependencies are built in throughout Your Account I think -- this just happens to be one I was looking at.


Code:
   define('IN_PHPBB', TRUE);
   include_once('./modules/' . $module_name . '/includes/phpbb_bbstuff.php');
   include_once('./modules/Forums/includes/bbcode.php');
   include_once('./modules/Forums/includes/functions_post.php');


I haven't tried it recently but I'm pretty sure you can't even run setup in the installation directory without having Forums present and the Forums tables all get loaded in rn_core.sql no?

I'm not saying we should try to remove all dependencies for 2.5 but we should acknowledge that they are there and plan our approaches to removing them for 3.0.
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
Forums ©
 

All logos and trademarks in this site are property of their respective owner.
The comments are property of their posters, all the rest © 2002-2011 by Raven

You can syndicate our news using the file xml

CSE HTML Validator Helped Clean up This Page! [Valid RSS] valid RSS 2.0 Valid robots.txt Stop Spam Harvesters, Join Project Honey Pot

Website engines core code is © copyright by PHP-Nuke but has been heavily patched and modified by myself and others.
PHP-Nuke is a free software released under the GNU/GPL.


:: fisubice phpbb2 style by Daz :: PHP-Nuke theme by www.nukemods.com ::
:: fisubice Theme Modified by the RavenNuke™ Team ::

:: W3C CSS Compliance Validation :: W3C HTML 4.01 Transitional Compliance Validation ::

zerosum